Skip to content

fix(voice): improve slide-to-cancel UX for voice message recording #6281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mahibi wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −15
Open

fix(voice): improve slide-to-cancel UX for voice message recording #6281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 11 additions & 13 deletions app/src/main/java/com/nextcloud/talk/chat/MessageInputFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import android.view.animation.Animation
import android.view.animation.Animation.AnimationListener
import android.view.animation.LinearInterpolator
import android.view.inputmethod.InputMethodManager
import android.widget.Chronometer
import android.widget.ImageButton
import android.widget.ImageView
import android.widget.LinearLayout
Expand Down Expand Up @@ -616,6 +617,7 @@ class MessageInputFragment : Fragment() {
binding.fragmentMessageInputView.audioRecordDuration.start()
chatActivity.chatViewModel.startAudioRecording(requireContext(), chatActivity.currentConversation!!)
showRecordAudioUi(true)
prevDx = event.x
}

MotionEvent.ACTION_CANCEL -> {
Expand Down Expand Up @@ -675,18 +677,10 @@ class MessageInputFragment : Fragment() {
resetSlider()
return@setOnTouchListener true
}
if (event.x < 0f) {
val dX = event.x
if (dX < prevDx) { // left
binding.fragmentMessageInputView.slideToCancelDescription.x -= INCREMENT
xcounter += INCREMENT
} else { // right
binding.fragmentMessageInputView.slideToCancelDescription.x += INCREMENT
xcounter -= INCREMENT
}

prevDx = dX
}
val dX = event.x - prevDx
prevDx = event.x
binding.fragmentMessageInputView.slideToCancelDescription.x += dX
xcounter -= dX

if (event.y < 0f) {
chatActivity.chatViewModel.postToRecordTouchObserver(INCREMENT)
Expand Down Expand Up @@ -1205,6 +1199,10 @@ class MessageInputFragment : Fragment() {
viewThemeUtils.platform.themeViewBackground(it, ColorRole.SURFACE_VARIANT)
}

binding.fragmentMessageInputView.findViewById<Chronometer>(R.id.audioRecordDuration)?.let {
viewThemeUtils.platform.themeViewBackground(it, ColorRole.SURFACE_VARIANT)
}

binding.fragmentMessageInputView.button?.let { viewThemeUtils.platform.colorImageView(it, ColorRole.PRIMARY) }

binding.fragmentMessageInputView.findViewById<ImageButton>(R.id.cancelReplyButton)?.let {
Expand Down Expand Up @@ -1306,7 +1304,7 @@ class MessageInputFragment : Fragment() {
private const val MENTION_AUTO_COMPLETE_ELEVATION = 6f
private const val MINIMUM_VOICE_RECORD_DURATION: Int = 1000
private const val ANIMATION_DURATION: Long = 750
private const val VOICE_RECORD_CANCEL_SLIDER_X: Int = -150
private const val VOICE_RECORD_CANCEL_SLIDER_X: Int = -300
private const val VOICE_RECORD_LOCK_THRESHOLD: Float = 100f
private const val INCREMENT = 8f
private const val CURSOR_KEY = "_cursor"
Expand Down
3 changes: 1 addition & 2 deletions app/src/main/res/layout/view_message_input.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,7 @@
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_centerInParent="true"
android:layout_toStartOf="@id/recordAudioButton"
android:layout_toEndOf="@id/audioRecordDuration"
android:translationX="30dp"
android:text="@string/nc_voice_message_slide_to_cancel"
android:textAlignment="viewStart"
android:textColor="?attr/colorControlNormal"
Expand Down
Loading