Skip to content

Migrate empty views to composable#6273

Merged
mahibi merged 8 commits into
masterfrom
style/noid/emptyChatViews
Jun 2, 2026
Merged

Migrate empty views to composable#6273
mahibi merged 8 commits into
masterfrom
style/noid/emptyChatViews

Conversation

@AndyScherzinger
Copy link
Copy Markdown
Member

@AndyScherzinger AndyScherzinger commented Jun 1, 2026

As a next steps in the chat migration, migrate the empty views to Composables

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger added this to the 24.1.0 milestone Jun 1, 2026
@AndyScherzinger AndyScherzinger requested a review from mahibi June 1, 2026 12:56
@AndyScherzinger AndyScherzinger added 3. to review Waiting for reviews technical debt Technical issue labels Jun 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/26756260723/artifacts/7332793659
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@AndyScherzinger AndyScherzinger force-pushed the style/noid/emptyChatViews branch from c89518c to d99d43b Compare June 1, 2026 15:14
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/26763881314/artifacts/7335747538
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@AndyScherzinger AndyScherzinger force-pushed the style/noid/emptyChatViews branch from d99d43b to 26f6b61 Compare June 1, 2026 15:52
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/26765936919/artifacts/7336443662
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@AndyScherzinger AndyScherzinger force-pushed the style/noid/emptyChatViews branch from 26f6b61 to aa1b9fd Compare June 2, 2026 07:19
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/26804745145/artifacts/7351478557
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@AndyScherzinger AndyScherzinger force-pushed the style/noid/emptyChatViews branch from aa1b9fd to 36eed92 Compare June 2, 2026 07:56
@mahibi
Copy link
Copy Markdown
Collaborator

mahibi commented Jun 2, 2026

thx Andy. I'm taking over and fix some things

AndyScherzinger and others added 8 commits June 2, 2026 22:37
@AndyScherzinger @mahibi
style: Migrate empty views to composable
d1ad7ae 
AI-assistant: Claude Code v2.1.152 (Claude Sonnet 4.6)
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger @mahibi
style: migrate toolbar to Compose ChatToolbar
d58001e 
AI-assistant: Claude Code v2.1.152 (Claude Sonnet 4.6)
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger @mahibi
style: migrate typing indicator to Composable
e54fdc5 
AI-assistant: Claude Code v2.1.152 (Claude Sonnet 4.6)
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@mahibi
fix to hide messages in lobby
efea5eb 
AI-assistant: Claude Code v2.1.142 (Claude Sonnet 4.6)
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
add onLongClick menu for call buttons
8305733 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
remove unused resources
ee5f5c2 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
reimplement threads toolbar menu
d1e14ae 
AI-assistant: Claude Code v2.1.142 (Claude Sonnet 4.6)
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
remove icons for menu items
c9019bb 
.. to align with the other items who also have no icons

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi force-pushed the style/noid/emptyChatViews branch from 36eed92 to c9019bb Compare June 2, 2026 20:53
@mahibi
Copy link
Copy Markdown
Collaborator

mahibi commented Jun 2, 2026

fixes to repair the lobby will come in a followup PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/26847395827/artifacts/7370011855
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@mahibi
Copy link
Copy Markdown
Collaborator

mahibi commented Jun 2, 2026

/backport to stable-24.0

@mahibi mahibi merged commit 2608099 into master Jun 2, 2026
16 of 18 checks passed
@mahibi mahibi deleted the style/noid/emptyChatViews branch June 2, 2026 22:16
@backportbot backportbot Bot mentioned this pull request Jun 2, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahibi mahibi Awaiting requested review from mahibi

Assignees

No one assigned

Labels

3. to review Waiting for reviews technical debt Technical issue

Projects

None yet

Milestone

24.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@AndyScherzinger @mahibi