Skip to content

Make wave form thicker #5723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AndyScherzinger wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Make wave form thicker #5723

AndyScherzinger wants to merge 3 commits into from
+10 −11

Conversation

@AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Jan 16, 2026 •
edited
Loading

Given that I am used to "thicker wave-forms" on other messengers, I played around with the values, see below.

I tend to prefer 3-fine

🖼️ Screenshots

🏚️ Before (2) 🏡 After (3) 🏡 After (3-fine) 🏡 After (4) 🏡 After (4-fine)
before width3 width3_fine16_not20 after_new width4_fine16_not20

🚧 TODO

  • get design feedback

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger added this to the 23.0.0 milestone Jan 16, 2026
@AndyScherzinger AndyScherzinger added design Related to the design 3. to review Waiting for reviews labels Jan 16, 2026
@AndyScherzinger AndyScherzinger marked this pull request as ready for review January 16, 2026 16:38
@AndyScherzinger AndyScherzinger force-pushed the style/noid/waveform branch 2 times, most recently from 4043947 to 99d1ab2 Compare January 16, 2026 17:01
@AndyScherzinger AndyScherzinger changed the title Make wave form thicker 2->4 Make wave form thicker Jan 16, 2026
@AndyScherzinger
style(wave): Make wave form thicker 2->4
e967b9a 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
style: Use dimens values where applicable/available
a8e9839 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
style: 3/fine
6287419 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5723.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2026

Codacy

Lint

TypemasterPR
Warnings9999
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahibi mahibi Awaiting requested review from mahibi

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

3. to review Waiting for reviews design Related to the design

Projects

None yet

Milestone

23.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@AndyScherzinger