feat(share): add public share-review API under OCP\Share\ShareReview by AndyScherzinger · Pull Request #61543 · nextcloud/server

AndyScherzinger · 2026-06-23T14:45:14Z

Summary

Introduces OCP\Share\Events\ShareReviewAccessCheckEvent as the canonical authorization gate event for ShareReview sources. The event carries the source name and share ID for listener context, implements deny-wins semantics, and stops propagation immediately on denial.
This is a discussed and agreed on measure to safeguard auditing-triggered share deletions throughout various apps using a "check back event mechanism", so apps can implement their support for this (any app that has shares basically, of any kind)

Docs at nextcloud/documentation#15223

Assisted-by: Claude Code:claude-sonnet-4-6
and
Assisted-by: Claude Code:claude-fable-5

TODO

testing in combination with deck and tables PRs for https://github.com/nextcloud/sharereview

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)
Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

The content of this PR was partly or fully generated using AI

AndyScherzinger · 2026-06-23T14:49:16Z

/backport to stable34

CarlSchwan

Need to run build/autoloaderchecker.sh

AndyScherzinger · 2026-07-02T21:49:22Z

@provokateurin @CarlSchwan worked on addressing your review comments.

provokateurin

Thanks for adding the explanation to the event docs.

Introduces OCP\Share\Events\ShareReviewAccessCheckEvent as the canonical authorization gate event for ShareReview sources. The event carries the source name and share ID for listener context, implements deny-wins semantics, and stops propagation immediately on denial. Assisted-by: ClaudeCode:claude-sonnet-4-6 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

…re\ShareReview Assisted-by: Claude Code:claude-fable-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

…ssCheckEvent Assisted-by: Claude Code:claude-fable-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

provokateurin · 2026-07-08T05:21:04Z

+		public readonly string $time = '1970-01-01 01:00:00',
+		public readonly string $action = '',
+		public readonly ?int $timestamp = null,


There should not be two fields for the creation time.

Also their names are not descriptive enough, they should be called creationTime/creationTimestamp and one has a default value and the other doesn't.

If you keep it like this, you can expect that they will be used incorrectly, because they're confusing 🙈

provokateurin · 2026-07-08T05:21:21Z

+		public readonly int $type,
+		public readonly string $recipient,
+		public readonly int $permissions = 1,
+		public readonly string $time = '1970-01-01 01:00:00',


This should be a proper ISO8601 string.

provokateurin · 2026-07-08T05:22:15Z

+	 * @param string $object Name or title of the shared object, such as a
+	 *                       file path or report name.
+	 * @param string $initiator User ID of the initiator.
+	 * @param int $type {@see \OCP\Share\IShare} type of the share.


Suggested change

* @param int $type {@see \OCP\Share\IShare} type of the share.

* @param IShare::TYPE_* $type {@see \OCP\Share\IShare} type of the share.

provokateurin · 2026-07-08T05:22:23Z

+	 * @param string $initiator User ID of the initiator.
+	 * @param int $type {@see \OCP\Share\IShare} type of the share.
+	 * @param string $recipient User ID of the owner or the token of a link.
+	 * @param int $permissions Permissions level of the share.


Suggested change

* @param int $permissions Permissions level of the share.

* @param int-mask-of<Constants::PERMISSION_*> $permissions Permissions level of the share.

provokateurin · 2026-07-08T05:23:46Z

+		public readonly string $time = '1970-01-01 01:00:00',
+		public readonly string $action = '',
+		public readonly ?int $timestamp = null,
+		public readonly bool $password = false,


Suggested change

public readonly bool $password = false,

public readonly bool $hasPassword = false,

provokateurin · 2026-07-08T05:24:12Z

+	 * @param int $type {@see \OCP\Share\IShare} type of the share.
+	 * @param string $recipient User ID of the owner or the token of a link.
+	 * @param int $permissions Permissions level of the share.
+	 * @param string $time Creation time of the share.


Suggested change

* @param string $time Creation time of the share.

* @param string $creationTime Creation time of the share as ISO8601 string.

provokateurin · 2026-07-08T05:24:26Z

+	 * @param int|null $timestamp Optional creation Unix timestamp, used for sorting.
+	 * @param bool $password Whether the share is password protected. Never
+	 *                       the password itself.
+	 * @param string|null $expiration Optional expiration date displayed for the share.


Suggested change

* @param string|null $expiration Optional expiration date displayed for the share.

* @param string|null $expirationDate Optional expiration date displayed for the share as ISO8601 string.

AndyScherzinger added this to the Nextcloud 35 milestone Jun 23, 2026

AndyScherzinger requested a review from a team as a code owner June 23, 2026 14:45

AndyScherzinger added the enhancement label Jun 23, 2026

AndyScherzinger requested review from Altahrim and ArtificialOwl and removed request for a team June 23, 2026 14:45

AndyScherzinger added the 2. developing Work in progress label Jun 23, 2026

AndyScherzinger requested review from leftybournes and salmart-dev June 23, 2026 14:45

AndyScherzinger added the feature: sharing label Jun 23, 2026

github-actions Bot added the AI assisted label Jun 23, 2026

AndyScherzinger marked this pull request as draft June 23, 2026 14:48

backportbot Bot added the backport-request label Jun 23, 2026

CarlSchwan reviewed Jun 23, 2026

View reviewed changes

Comment thread lib/public/Share/ShareReview/Events/ShareReviewAccessCheckEvent.php

AndyScherzinger force-pushed the feat/noid/shareReviewDeleteEvent branch 6 times, most recently from c4ea0a9 to af59b39 Compare June 23, 2026 17:03

AndyScherzinger marked this pull request as ready for review June 23, 2026 17:44

AndyScherzinger added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 25, 2026

This was referenced Jun 25, 2026

docs(events): Add ShareReviewAccessCheckEvent nextcloud/documentation#15223

Open

🕵️ Add sharereview support nextcloud/tables#2711

Draft

provokateurin reviewed Jun 30, 2026

View reviewed changes

Comment thread lib/public/Share/ShareReview/Events/ShareReviewAccessCheckEvent.php Outdated

AndyScherzinger force-pushed the feat/noid/shareReviewDeleteEvent branch 2 times, most recently from f306220 to d45d8e1 Compare July 2, 2026 21:42

AndyScherzinger changed the title ~~feat(share): add ShareReviewAccessCheckEvent to OCP public API~~ feat(share): add public share-review API under OCP\Share\ShareReview Jul 2, 2026

AndyScherzinger force-pushed the feat/noid/shareReviewDeleteEvent branch from d45d8e1 to e46b015 Compare July 3, 2026 16:59

AndyScherzinger requested a review from susnux July 6, 2026 18:17

provokateurin requested changes Jul 6, 2026

View reviewed changes

Comment thread lib/public/Share/ShareReview/IShareReviewSource.php Outdated

Comment thread lib/public/Share/ShareReview/IShareReviewSource.php Outdated

Comment thread tests/lib/Share20/ShareReview/RegisterShareReviewSourceEventTest.php Outdated

AndyScherzinger added 5 commits July 7, 2026 14:34

feat(share): move share-review source interface and events to OCP\Sha…

492ecc3

…re\ShareReview Assisted-by: Claude Code:claude-fable-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

docs(share): explain dispatcher and listener roles of ShareReviewAcce…

021a3d8

…ssCheckEvent Assisted-by: Claude Code:claude-fable-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

feat(share): replace getShares() array shape with ShareReviewEntry class

df285d5

Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

test(share): use mocks instead of an anonymous class for source stubs

fa57f02

Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

AndyScherzinger force-pushed the feat/noid/shareReviewDeleteEvent branch from e46b015 to fa57f02 Compare July 7, 2026 12:51

provokateurin requested changes Jul 8, 2026

View reviewed changes

	* @param int $type {@see \OCP\Share\IShare} type of the share.
	* @param IShare::TYPE_* $type {@see \OCP\Share\IShare} type of the share.

	* @param int $permissions Permissions level of the share.
	* @param int-mask-of<Constants::PERMISSION_*> $permissions Permissions level of the share.

	public readonly bool $password = false,
	public readonly bool $hasPassword = false,

	* @param string $time Creation time of the share.
	* @param string $creationTime Creation time of the share as ISO8601 string.

	* @param string\|null $expiration Optional expiration date displayed for the share.
	* @param string\|null $expirationDate Optional expiration date displayed for the share as ISO8601 string.

Uh oh!

Uh oh!

Conversation

AndyScherzinger commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

TODO

Checklist

AI (if applicable)

Uh oh!

AndyScherzinger commented Jun 23, 2026

Uh oh!

CarlSchwan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

AndyScherzinger commented Jul 2, 2026

Uh oh!

provokateurin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

provokateurin Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

provokateurin Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

provokateurin Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

provokateurin Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

provokateurin Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

provokateurin Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

provokateurin Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AndyScherzinger commented Jun 23, 2026 •

edited

Loading