Skip to content

feat(federation): more logs on share failing #61383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArtificialOwl wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −0
Open

feat(federation): more logs on share failing #61383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions apps/cloud_federation_api/lib/Controller/RequestHandlerController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ public function addShare($shareWith, $name, $description, $providerId, $owner, $
Http::STATUS_BAD_REQUEST
);
$response->throttle();
$this->logger->info('user does not exist', ['user' => $shareWith]);
return $response;
}
}
Expand All @@ -171,6 +172,7 @@ public function addShare($shareWith, $name, $description, $providerId, $owner, $
Http::STATUS_BAD_REQUEST
);
$response->throttle();
$this->logger->info('group does not exist', ['user' => $shareWith]);
return $response;
}
}
Expand Down Expand Up @@ -208,11 +210,13 @@ public function addShare($shareWith, $name, $description, $providerId, $owner, $
}

try {
$this->logger->info('share creation', ['sharedBy' => $sharedBy, 'sharedByDisplayName' => $sharedByDisplayName, 'ownerDisplayName' => $ownerDisplayName]);
$provider = $this->cloudFederationProviderManager->getCloudFederationProvider($resourceType);
$share = $this->factory->getCloudFederationShare($shareWith, $name, $description, $providerId, $owner, $ownerDisplayName, $sharedBy, $sharedByDisplayName, '', $shareType, $resourceType);
$share->setProtocol($protocol);
$provider->shareReceived($share);
} catch (ProviderDoesNotExistsException|ProviderCouldNotAddShareException $e) {
$this->logger->error('issue with share provider', ['exception' => $e]);
return new JSONResponse(
['message' => $e->getMessage()],
Http::STATUS_NOT_IMPLEMENTED
Expand All @@ -239,6 +243,7 @@ public function addShare($shareWith, $name, $description, $providerId, $owner, $
}
}

$this->logger->info('share created', ['data' => $responseData]);
return new JSONResponse($responseData, Http::STATUS_CREATED);
}

Expand Down
Loading