[stable34] fix(taskprocessing): claim tasks atomically so parallel workers don't duplicate#61367
Open
backportbot[bot] wants to merge 6 commits into
Open
[stable34] fix(taskprocessing): claim tasks atomically so parallel workers don't duplicate#61367backportbot[bot] wants to merge 6 commits into
backportbot[bot] wants to merge 6 commits into
Conversation
backportbot
Bot
requested review from
ArtificialOwl,
benjaminfrueh,
icewind1991,
leftybournes,
marcelklehr,
oleksandr-nc and
salmart-dev
and removed request for
a team
backportbot
Bot
added
bug
3. to review
marcelklehr
approved these changes
Jun 17, 2026
AndyScherzinger
approved these changes
Jun 17, 2026
AndyScherzinger
approved these changes
Jun 17, 2026
AndyScherzinger
force-pushed
the
backport/61053/stable34
branch
from
4d4e119 to
0e8ad02
Compare
…ite index Replace the worker retry/ignore-list claim-loop with a single atomic SELECT ... FOR UPDATE SKIP LOCKED claim (SQLite bounded-retry fallback), preserving the no-duplicate guarantee while removing the thundering-herd contention that throttled backlog draining. Add a (status,type,last_updated) index via the table-creating migration + db:add-missing-indices listener. Signed-off-by: Yoan Bozhilov <bygadd@gmail.com> Assisted-by: Claude Code:claude-opus-4-8
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Marcel Klehr <mklehr@gmx.net>
…Oracle fallback Address review feedback (@marcelklehr, Copilot): - lockTask claims only SCHEDULED tasks (was status != RUNNING) and stamps started_at in the same atomic UPDATE, so a finished task cannot be re-claimed and the external-provider claim path records started_at as well. - claimWithBoundedRetry re-reads after lockTask instead of a follow-up UPDATE. - Oracle joins SQLite on the bounded-retry fallback: Oracle cannot combine a row-limiting clause with FOR UPDATE (ORA-02014), which failed the claim tests on Oracle CI. - Reword the worker docblock/comments to "prefer oldest available" (parallel SKIP LOCKED does not guarantee a strict global order). - Add a regression test that lockTask does not resurrect a finished task. Signed-off-by: Yoan Bozhilov <bygadd@gmail.com> Assisted-by: Claude Code:claude-opus-4-8
Per review feedback: note in the lockTask docblock that the guard changed from `status != RUNNING` to `status = SCHEDULED`, and that callers must now treat a 0 return as "the task is no longer claimable" rather than assuming success. Signed-off-by: Yoan Bozhilov <bygadd@gmail.com> Assisted-by: Claude Code:claude-opus-4-8
The new public IManager::claimNextScheduledTask lands in master (35.0.0), not 34.0.0. Addresses review feedback. Signed-off-by: Yoan Bozhilov <bygadd@gmail.com> Assisted-by: Claude Code:claude-opus-4-8
AndyScherzinger
force-pushed
the
backport/61053/stable34
branch
from
0e8ad02 to
86b4dc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #61053