fix: Use token expiration for ephemeral sessions#61295
Merged
Merged
Conversation
come-nc
requested review from
CarlSchwan,
nfebe,
salmart-dev and
sorbaugh
and removed request for
a team
Contributor
Author
|
/backport to stable34 |
susnux
approved these changes
Jun 15, 2026
This simplifies the code a lot. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
…ession Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/fix-ephemeral-session-expiration
branch
from
7b3ffa1 to
088dba3
Compare
cristianscheid
approved these changes
Jun 15, 2026
This was referenced Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since #56215 ephemeral sessions can be used for all endpoints for 5 minutes, let’s remove the middleware and flagging in-session system and rely on the token expiration stored in database instead.
This avoids any issue related to the PHP session expiring, the renewed session will keep the same expiration.
Checklist
3. to review, feature component)stable32)AI (if applicable)