fix(maintenance): allow AppAPI to serve requests during maintenance mode#61294
Open
oleksandr-nc wants to merge 1 commit into
Open
fix(maintenance): allow AppAPI to serve requests during maintenance mode#61294oleksandr-nc wants to merge 1 commit into
oleksandr-nc wants to merge 1 commit into
Conversation
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows AppAPI to work during the maintenance mode.
Reason? When admin enables maintenance mode, Nextcloud returns a
503for every app route. This also shuts down AppAPI's own routes and itsocccommands. But maintenance mode is when admins run backups and upgrades, so today this can break the whole ExApp setup.Main findings from bug-reports:
401/404errors. If HaRP restarts during the maintenance window, every ExApp route stops working.occ app_api:*commands are not loaded during maintenance, so an admin cannot manage or recover ExApps from the command line either.Conditions:
needUpgrade()must be false) - as there can be a pending upgrade of AppAPI.Everything else stays exactly as before (I hope 🤗)
We would also like to request a backport this for Nextcloud 34, for which we are already asking admins to use HaRP - and with it, this problem looks more serious.
Note: WebDAV and the other entry points are untouched. ExApp-provided dynamic
occcommands (loaded fromregister_command.php) are intentionally not registered during maintenance.Checklist
3. to review, feature component)stable32)AI (if applicable)