feat(systemtag): Add $user context to create and update tag#59222
Open
feat(systemtag): Add $user context to create and update tag#59222
Conversation
Signed-off-by: Louis Chmn <louis@chmn.me>
artonge
changed the title
artonge
requested review from
ArtificialOwl,
CarlSchwan,
come-nc and
provokateurin
and removed request for
a team
artonge
added
2. developing
provokateurin
requested changes
Mar 26, 2026
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Otherwise it's a breaking change
| * @since 31.0.0 Can throw TagCreationForbiddenExceptionif user doesn't have the right to create a new tag | ||
| */ | ||
| public function createTag(string $tagName, bool $userVisible, bool $userAssignable): ISystemTag; | ||
| public function createTag(string $tagName, bool $userVisible, bool $userAssignable, ?IUser $user): ISystemTag; |
Member
There was a problem hiding this comment.
Suggested change
| public function createTag(string $tagName, bool $userVisible, bool $userAssignable, ?IUser $user): ISystemTag; | |
| public function createTag(string $tagName, bool $userVisible, bool $userAssignable, ?IUser $user = null): ISystemTag; |
| * @since 31.0.0 `$color` parameter added | ||
| */ | ||
| public function updateTag(string $tagId, string $newName, bool $userVisible, bool $userAssignable, ?string $color); | ||
| public function updateTag(string $tagId, string $newName, bool $userVisible, bool $userAssignable, ?string $color, ?IUser $user): void; |
Member
There was a problem hiding this comment.
Suggested change
| public function updateTag(string $tagId, string $newName, bool $userVisible, bool $userAssignable, ?string $color, ?IUser $user): void; | |
| public function updateTag(string $tagId, string $newName, bool $userVisible, bool $userAssignable, ?string $color, ?IUser $user = null): void; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would allow different use cases than what is possible now.