Skip to content

feat(files_external/s3): make some auth labels clearer #59204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshtrichards wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(files_external/s3): make some auth labels clearer #59204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0010042
feat(files_external/s3): Adjust auth meth/parameter field names
joshtrichards Mar 25, 2026
b7bdd76
feat(files_external/s3): rename legacy signature (v2) for clarity
joshtrichards Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/files_external/lib/Lib/Auth/AmazonS3/AccessKey.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ public function __construct(IL10N $l) {
$this
->setIdentifier('amazons3::accesskey')
->setScheme(self::SCHEME_AMAZONS3_ACCESSKEY)
->setText($l->t('Access key'))
->setText($l->t('Static credentials'))
->addParameters([
new DefinitionParameter('key', $l->t('Access key')),
(new DefinitionParameter('secret', $l->t('Secret key')))
new DefinitionParameter('key', $l->t('Access key ID')),
(new DefinitionParameter('secret', $l->t('Secret access key')))
->setType(DefinitionParameter::VALUE_PASSWORD),
]);
}
Expand Down
2 changes: 1 addition & 1 deletion apps/files_external/lib/Lib/Backend/AmazonS3.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public function __construct(IL10N $l, AccessKey $legacyAuth) {
->setDefaultValue(true),
(new DefinitionParameter('use_path_style', $l->t('Enable Path Style')))
->setType(DefinitionParameter::VALUE_BOOLEAN),
(new DefinitionParameter('legacy_auth', $l->t('Legacy (v2) authentication')))
(new DefinitionParameter('legacy_auth', $l->t('Use Legacy S3 signing (v2)')))
->setType(DefinitionParameter::VALUE_BOOLEAN),
(new DefinitionParameter('useMultipartCopy', $l->t('Enable multipart copy')))
->setType(DefinitionParameter::VALUE_BOOLEAN)
Expand Down
Loading