fix(ShareApiController): fix listing of remote shares for the owner#59163
Open
fix(ShareApiController): fix listing of remote shares for the owner#59163
Conversation
Contributor
Author
|
/backport! to stable32 |
szaimen
force-pushed
the
enh/noid/fix-remote-shares-in-controller
branch
2 times, most recently
from
1c2b09e to
a34738e
Compare
szaimen
added
3. to review
szaimen
requested review from
a team,
SebastianKrupinski and
kesselb
as code owners
szaimen
requested review from
Altahrim,
icewind1991,
leftybournes and
salmart-dev
and removed request for
a team
Signed-off-by: Simon L. <szaimen@e.mail.de>
szaimen
force-pushed
the
enh/noid/fix-remote-shares-in-controller
branch
from
a34738e to
57967bb
Compare
Contributor
Author
|
/backport to stable33 |
provokateurin
requested changes
Mar 26, 2026
Comment on lines
+1732
to
+1733
| // Add federated sharing as a provider only if it's allowed | ||
| if ($this->shareManager->outgoingServer2ServerSharesAllowed()) { | ||
| // Include federated sharing whenever the provider is available for the user. | ||
| if ($this->shareManager->shareProviderExists(IShare::TYPE_REMOTE)) { |
Member
There was a problem hiding this comment.
This doesn't look right to me. You probably want to add the check if the provider exists in addition to the check if federated sharing is allowed. These are two different things.
Contributor
Author
There was a problem hiding this comment.
you are right. Probably the below line changes are enough to make it work.
szaimen
commented
Mar 26, 2026
szaimen
force-pushed
the
enh/noid/fix-remote-shares-in-controller
branch
from
9ee1b57 to
fb8682b
Compare
szaimen
force-pushed
the
enh/noid/fix-remote-shares-in-controller
branch
from
fb8682b to
a07d1e2
Compare
szaimen
added
2. developing
provokateurin
requested changes
Mar 26, 2026
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
I don't understand the issue or the fix based on the PR description and the code changes.
Comment on lines
-1857
to
+1864
| if ($this->shareManager->outgoingServer2ServerSharesAllowed()) { | ||
| if ($this->shareManager->shareProviderExists(IShare::TYPE_REMOTE)) { | ||
| $federatedShares = $this->shareManager->getSharesBy( | ||
| $this->userId, IShare::TYPE_REMOTE, $node, $reShares, -1, 0 | ||
| ); | ||
| $shares = array_merge($shares, $federatedShares); | ||
| } | ||
|
|
||
| if ($this->shareManager->outgoingServer2ServerGroupSharesAllowed()) { | ||
| if ($this->shareManager->shareProviderExists(IShare::TYPE_REMOTE_GROUP)) { |
Member
There was a problem hiding this comment.
Still the same, your're changing what is checked.
…owner Signed-off-by: Simon L. <szaimen@e.mail.de>
szaimen
force-pushed
the
enh/noid/fix-remote-shares-in-controller
branch
from
a07d1e2 to
11b1539
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following problem:
AI (if applicable)