[stable32] fix(Propagator): rollback transaction if it fails #58131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot
bot
requested review from
AndyScherzinger,
CarlSchwan and
ChristophWurst
CarlSchwan
approved these changes
Feb 6, 2026
CarlSchwan
force-pushed
the
backport/57733/stable32
branch
from
685b611 to
7bbd260
Compare
CarlSchwan
requested review from
Altahrim,
ArtificialOwl,
icewind1991 and
leftybournes
and removed request for
a team
salmart-dev
reviewed
Feb 6, 2026
| try { | ||
| $this->connection->beginTransaction(); | ||
|
|
||
| $query = $this->connection->getQueryBuilder(); |
Contributor
There was a problem hiding this comment.
The alignment here is off
salmart-dev
approved these changes
Feb 6, 2026
Contributor
salmart-dev
left a comment
salmart-dev
left a comment
There was a problem hiding this comment.
Besides a formatting issue LGTM
Altahrim
approved these changes
Feb 6, 2026
Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
backport/57733/stable32
branch
from
7bbd260 to
481cd6a
Compare
cristianscheid
approved these changes
Feb 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #57733
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.