Exclude hidden files from recent recommendations

[blkqi]

Resolves #71 by

• Restructuring getMostRecentRecommendation to better allow for filtering of results.
• Implementing filter isNodeExcluded in order to exclude nodes which are either hidden files or descendants of hidden folders. A traversal of the file system hierarchy is necessary to find hidden ancestors, which greatly reduces the worst-case time complexity.
• Respecting the user's configuration selection regarding hidden files.

The number of candidate files is arbitrarily limited by 10 times the actual number requested.

[ChristophWurst]

won't you run into an infinite loop here?

I think you would be better off with recursion. If the current node is hidden, you return false. If there is a parent you return $this->isNodeExcluded($node->getParent(), $showHidden);. Else you return false.

[blkqi]

Thank you for taking a look!

The sequence ends when a dotfile is found (return true) or the root node is found (break). In other words, it is always bounded by the depth of the node. If there were a clearer way to identify the root node other than by exception handling then I would be more than happy to use it.

While I agree that recursion is generally a more natural approach to tree traversal problems, I don't think anything is lost in this context by iterating. And in the recursive case, we would want to introduce a new function so that isNodeExcluded can be adapted to other types of exclusions related to the target node (name, mimetype, tag, etc.).

[skjnldsv]

Please rebase? 🙈