-
Notifications
You must be signed in to change notification settings - Fork 83
feat: add rank voting feature merge chosenrank with 8.1.4 refactorings #4194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
reworked from git@github.com:vinimoz/polls.git rank-vote-feature-vue3 TRAPPE Vincent <trappe.vincent@laposte.Net>
|
@artlog Welcome and thanks for participation. First to make sure, I understand the intention of this PR right:
Based on this assumption:
Important
|
|
@dartcafe My purpose is to get a base voting system : majority judgement #3472 , libraries to handle this don't need textual value of choice but rather a numeric ordered rank. Yet i rely on alphanumerical sort and label my choices with a ordered prefix. After test on this version, votes are not recorded while it was working on original version. So this request can wait and might even be deleted, this is somehow why i selected a Draft one. |
|
@dartcafe i have a working version with new generic variant for rank polls on 8.1.4 that support both Text and Date. |
|
This is the point. => it uses this repo main branch, it is possible to select another branch than main, but none are matching 8.1.4 and selecting a v8.1.4 tag does compare correctly but prevent creating a PR ( no button ).
So i blindly created #4199 ... |
|
There is no 8.2.0 branch. 8.1.4 or any ales are tags. You can't merge into tags, just branches. In this case main is the correct branch to request the merge to. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |

reworked from
git@github.com:vinimoz/polls.git rank-vote-feature-vue3 TRAPPE Vincent trappe.vincent@laposte.Net