Skip to content

Conversation

@artlog
Copy link

@artlog artlog commented Jul 30, 2025

reworked from
git@github.com:vinimoz/polls.git rank-vote-feature-vue3 TRAPPE Vincent trappe.vincent@laposte.Net

reworked from
git@github.com:vinimoz/polls.git rank-vote-feature-vue3
TRAPPE Vincent <trappe.vincent@laposte.Net>
@dartcafe
Copy link
Collaborator

dartcafe commented Jul 30, 2025

@artlog Welcome and thanks for participation.
I just looked briefly into the changes. But first things I observed:

First to make sure, I understand the intention of this PR right:

  • The PR introduces a new variant for the voting of existing options
  • Voting should be possible as a numeric or ordering vote instead of yes|no|maybe
  • Defining the winner can be calculated by different algorithms
    • simple one is to add the ranks for an option

Based on this assumption:

  • You created a new poll_type which makes the ranked voting only available as a text poll
  • Actually it is not a new poll type but a new voting variant. You find that property as a poll configuration property, added early for that use case
  • what is the purpose of the property chosen_rank as a poll's attribute? Shouldn't it rather be a vote value?

Important

  • In any case add all comments in English
  • run the linters regularly to make sure the code is according to the style guides
  • sign off your commits correctly as requested by the Nextcloud style guide
  • make sure to rebase your branch regularly, since I am still changing a lot of code lines; Merge conflicts are to be expected

@artlog
Copy link
Author

artlog commented Jul 30, 2025

@dartcafe
I merged an existing code and i am not able to justify design. I don't handle poll design enough to argue.

My purpose is to get a base voting system : majority judgement #3472 , libraries to handle this don't need textual value of choice but rather a numeric ordered rank. Yet i rely on alphanumerical sort and label my choices with a ordered prefix.
But i didn't even started to integrate server side polling computation, i would like to reuse existing libraries.
This would anyway requires a rework.

After test on this version, votes are not recorded while it was working on original version.
I will take care of your comment in further requests.

So this request can wait and might even be deleted, this is somehow why i selected a Draft one.

@artlog
Copy link
Author

artlog commented Aug 3, 2025

@dartcafe i have a working version with new generic variant for rank polls on 8.1.4 that support both Text and Date.
branch variant_generic_unified in my repository artlog.
It is on 8.1.4 but not prepared for a merge in main that is still moving.
I didn't find how to request a merge on other branches than main , even origin/enh/prepare-voting-variants is not proposed, and i i select a tag v8.1.4 github does not propose a pull request.
How do i proceed ?

@dartcafe
Copy link
Collaborator

dartcafe commented Aug 3, 2025

  • Fork this repo
  • Change using a branch in your fork
  • Create a PR from your branch and point it to this repo instead of yours.

@artlog
Copy link
Author

artlog commented Aug 3, 2025

  • Fork this repo -> this is done already
  • Change using a branch in your fork : i did create many branches with git....
  • Create a PR from your branch and point it to this repo instead of yours

This is the point.

=> it uses this repo main branch, it is possible to select another branch than main, but none are matching 8.1.4 and selecting a v8.1.4 tag does compare correctly but prevent creating a PR ( no button ).

Capture d’écran du 2025-08-03 16-51-24

So i blindly created #4199 ...

@dartcafe
Copy link
Collaborator

dartcafe commented Aug 3, 2025

There is no 8.2.0 branch. 8.1.4 or any ales are tags. You can't merge into tags, just branches.

In this case main is the correct branch to request the merge to.

@artlog
Copy link
Author

artlog commented Aug 5, 2025

Pull request #4200 is replacing this one ( and replacing #4199 too )

@artlog artlog closed this Aug 5, 2025
@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants