Votes rank feature enabled #3930

dartcafe · 2025-03-24T16:56:10Z

No description provided.

dartcafe

First quick look.

dartcafe · 2025-03-24T17:06:16Z

lib/Db/Poll.php

-	public const TYPE_TEXT = 'textPoll';
+	public const TYPE_IND_TEXT = 'textIndPoll';
+	public const TYPE_RANK_TEXT = 'textRankPoll';


I would prefer leaving the constants unchanged. Don't change the constants. Just add the new one (TYPE_RANKED_TEXT).

Or better TYPE_TEXT_RANKED

if it doesnt mind u i've keep TYPE_RANKED_POOL like my field is textRankPool and as i'm lazy

It is because of sorting and hierarchical context. At first it is a text poll and second there is a voting variation.

That is not important, but changing the existing types is no good idea. Already existing polls are marked as textPoll inside the database.

Leaving the existent constants name results in less code changes to review.

dartcafe · 2025-03-24T17:08:56Z

lib/Db/Poll.php

 	protected string $access = '';
 	protected int $anonymous = 0;
 	protected int $allowMaybe = 0;
+	protected $choosenRank = [];


Avoid array as database type. I am not sure, if it work with all db engines properly.
Prefer a string and add getters which decode and encode the string into an array.
BTW: typo choosen => chosen

ya right. I've change it to string i will test the modification.

dartcafe · 2025-03-24T17:11:02Z

src/js/components/Configuration/ConfigRankOptions.vue

@@ -0,0 +1,171 @@
+<template>
+  <div class="option-container">
+    <!-- Menu déroulant pour sélectionner une option -->


Please. Comments always in English language!

vinimoz · 2025-03-25T01:41:52Z

Sorry, but i'm a newbie, in github, vue, etc 😄 . I've proceed with modifications and fix. I've try several time to put in the branch master-7, Rank votes features, without luck, i always get access denied. I will put the update on my fork

vinimoz · 2025-03-25T05:45:56Z

After several tries, i manage to do a commit with the changes. I can see my commit. On the commit. I was trying to change the mode draft but i think i cannot do that.

dartcafe · 2025-03-25T17:56:18Z

Sorry, but i'm a newbie, in github, vue, etc 😄 . I've proceed with modifications and fix. I've try several time to put in the branch master-7, Rank votes features, without luck, i always get access denied. I will put the update on my fork

Don't care. That's the way I went through, when I started here.

dartcafe · 2025-03-25T17:59:29Z

After several tries, i manage to do a commit with the changes. I can see my commit. On the commit. I was trying to change the mode draft but i think i cannot do that.

You can't change it, because you are not a member of the nextcloud organisation (organisation here on Github). All changes are done inside your branch and end here in this PR as soon as you commit them to your branch (in your repo)

dartcafe · 2025-03-25T19:35:25Z

@vinimoz To make the changes better readable please run composer run cs:fix.

You could also run eslint (npm run lint:fix)

vinimoz · 2025-03-26T18:44:29Z

Yesterday, i commit and other on. eslint doenst give me any more error. Regarding phpcs and php-cs for lib directory
php-cs : Found 82 of 197 files that can be fixed in 1.444 seconds, 23.12 MB memory used
phpcs: PHPCBF CAN FIX THE 398 MARKED SNIFF VIOLATIONS AUTOMATICALLY
I don't put the fix options and commit it as i modify only 3 files in lib directory. If u want i do it an commit it.

Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>

This reverts commit 46aa777. Signed-off-by: dartcafe <github@dartcafe.de>

This reverts commit c5a55ab. Signed-off-by: dartcafe <github@dartcafe.de>

Signed-off-by: vinimoz <trappe.vincent@laposte.net>

- Remove modification of textPoll to textIndPoll - Change of array to string - Updates translation - Some fix Signed-off-by: vinimoz <trappe.vincent@laposte.net>

Signed-off-by: vinimoz <trappe.vincent@laposte.net>

…nt fix Signed-off-by: vinimoz <trappe.vincent@laposte.net>

dartcafe · 2025-03-27T19:09:31Z

something is not clean here.

You commited reverted commits from the master-7 branch (affecting the translation files). How did you create your branch?

vinimoz · 2025-03-28T02:50:39Z

Oups sorry, maybe it's my fault it coz someone else was working on my branch of the fork, Rank_votes_feature ?. Yesterday, i try to commit on the pr3930, as i was seeing my commit there. After realize i haven't the right, after go back on the correct place, i do a mistake a create a branch 3930_commit on my main branch by error. So i after i merge it with Rank_vote s_feature and delete it the 3930_commit. After i've tried to fight to fix all DCO. To create my branch originally after the fork i do, after i remember, i clone it, fetch the upstream, i do gitcheckout -b Rank_votes_feature. Its what i remember.

…

On 27/03/2025 09:09, René Gieling wrote: something is not clean here. You commited reverted commits from the master-7 branch (affecting the translation files). How did you create your branch? — Reply to this email directly, view it on GitHub <#3930 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AW7C5TTF4CFZBE25ZDVVVV32WQ5HBAVCNFSM6AAAAABZVOBHUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONJZGE2DGMBZGA>. You are receiving this because you were mentioned.Message ID: ***@***.***> dartcafe*dartcafe* left a comment (nextcloud/polls#3930) <#3930 (comment)> something is not clean here. You commited reverted commits from the master-7 branch (affecting the translation files). How did you create your branch? — Reply to this email directly, view it on GitHub <#3930 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AW7C5TTF4CFZBE25ZDVVVV32WQ5HBAVCNFSM6AAAAABZVOBHUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONJZGE2DGMBZGA>. You are receiving this because you were mentioned.Message ID: ***@***.***>

dartcafe · 2025-04-21T16:01:09Z

@vinimoz Are you still working on this?

I would prefer to close this PR out of the following reasons:

This PR is based on v7 and v7 will slowly become legacy, since the v8 is nearly about to leave beta state
v8's code base is not compatible to v7's, so any changes will have a short life
I already prepared voting variants here
A ranked voting is rather a voting variant but a poll type.
We should think the implementation first from the UI.
I prefer another UI for ranked votes (something like moving options by drag and drop into an order instead of entering numbers)

vinimoz · 2025-04-24T19:55:43Z

I’ve stopped working on it since, u told me something wrong happens, I had modified some files that ideally shouldn’t have been changed. That was my understanding up to that point. That said, throughout the development, I made an effort to keep changes to a minimum and maintain the flexibility you had implemented for the other voting types. With the current setup, we can proceed with votes, smiley like, score voting, letter grades, majority judgment, Borda, Nauru, and Condorcet. I do agree that a drag-and-drop feature would improve usability, especially for Condorcet, and could definitely be refined. Regarding the version, I was aware of the situation. That’s one of the reasons I aimed to deliver a usable version as quickly as possible to avoid blocking progress. Migrating to Vue 3 shouldn't be a major issue. Also, I needed those improvements fairly quickly for our political group. I understand your point of view. What I don’t quite understand is why I was asked to fix or change things if, in the end, it wasn’t what you were looking for. It would’ve simply been more transparent and respectful to clarify that from the beginning. Le 21/04/2025 à 06:01, René Gieling a écrit :

…

@vinimoz <https://github.com/vinimoz> Are you still working on this? I would prefer to close this PR out of the following reasons: * This PR is based on v7 and v7 will slowly become legacy, since the v8 is nearly about to leave beta state * v8's code base is not compatible to v7's, so any changes will have a short life * I already prepared voting variants here <#3973> A ranked voting is rather a voting variant but a poll type. * We should think the implementation first from the UI. I prefer another UI for ranked votes (something like moving options by drag and drop into an order instead of entering numbers) — Reply to this email directly, view it on GitHub <#3930 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AW7C5TXQGKZKG53OZ7JBIVT22UI5ZAVCNFSM6AAAAABZVOBHUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJYHA4TGMZQGY>. You are receiving this because you were mentioned.Message ID: ***@***.***> *dartcafe* left a comment (nextcloud/polls#3930) <#3930 (comment)> @vinimoz <https://github.com/vinimoz> Are you still working on this? I would prefer to close this PR out of the following reasons: * This PR is based on v7 and v7 will slowly become legacy, since the v8 is nearly about to leave beta state * v8's code base is not compatible to v7's, so any changes will have a short life * I already prepared voting variants here <#3973> A ranked voting is rather a voting variant but a poll type. * We should think the implementation first from the UI. I prefer another UI for ranked votes (something like moving options by drag and drop into an order instead of entering numbers) — Reply to this email directly, view it on GitHub <#3930 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AW7C5TXQGKZKG53OZ7JBIVT22UI5ZAVCNFSM6AAAAABZVOBHUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJYHA4TGMZQGY>. You are receiving this because you were mentioned.Message ID: ***@***.***>

artlog · 2025-08-05T07:24:27Z

@vinimoz i am pushing forward this with #4200 pull request to converge for this enhancement to see the light. PRocess still ongoing.

dartcafe · 2025-08-18T10:46:32Z

@vinimoz I think this is superseded by #4200. So I will close it here.

And maybe you want to have a look at it, since @artlog adopted your work there.

dartcafe added the enhancement label Mar 24, 2025

dartcafe added this to the backlog milestone Mar 24, 2025

dartcafe mentioned this pull request Mar 24, 2025

poll variant : Condorcet method support #3897

Open

1 task

dartcafe commented Mar 24, 2025

View reviewed changes

dartcafe marked this pull request as draft March 24, 2025 17:20

dartcafe self-assigned this Mar 24, 2025

vinimoz approved these changes Mar 25, 2025

View reviewed changes

vinimoz force-pushed the Rank_votes_feature branch from d2b16e6 to a918de1 Compare March 26, 2025 23:43

hamza221 and others added 7 commits March 26, 2025 14:02

fix: list polls after taking over

3ad0263

Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>

Revert "Fix(l10n): Update translations from Transifex"

2fd4f9d

This reverts commit 46aa777. Signed-off-by: dartcafe <github@dartcafe.de>

Revert "Fix(l10n): Update translations from Transifex"

64d35d7

This reverts commit c5a55ab. Signed-off-by: dartcafe <github@dartcafe.de>

Votes rank feature enabled

bd4a09b

Signed-off-by: vinimoz <trappe.vincent@laposte.net>

feat: fix votes ranking

4e8bc8d

- Remove modification of textPoll to textIndPoll - Change of array to string - Updates translation - Some fix Signed-off-by: vinimoz <trappe.vincent@laposte.net>

Trigger PR status update

caab317

Signed-off-by: vinimoz <trappe.vincent@laposte.net>

feat: ajout - Add back DEFAULT_CHOSEN_RANK instead use database. esli…

007a63e

…nt fix Signed-off-by: vinimoz <trappe.vincent@laposte.net>

vinimoz force-pushed the Rank_votes_feature branch from a918de1 to 007a63e Compare March 27, 2025 00:06

dartcafe removed this from the backlog milestone Aug 6, 2025

dartcafe closed this Aug 18, 2025

Votes rank feature enabled #3930

Votes rank feature enabled #3930

Uh oh!

Conversation

dartcafe commented Mar 24, 2025

Uh oh!

dartcafe left a comment

Choose a reason for hiding this comment

Uh oh!

dartcafe Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

vinimoz Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

dartcafe Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dartcafe Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

vinimoz Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

dartcafe Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

vinimoz Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

vinimoz commented Mar 25, 2025

Uh oh!

vinimoz commented Mar 25, 2025

Uh oh!

dartcafe commented Mar 25, 2025

Uh oh!

dartcafe commented Mar 25, 2025

Uh oh!

dartcafe commented Mar 25, 2025

Uh oh!

vinimoz commented Mar 26, 2025

Uh oh!

dartcafe commented Mar 27, 2025

Uh oh!

vinimoz commented Mar 28, 2025 via email

Uh oh!

dartcafe commented Apr 21, 2025

Uh oh!

vinimoz commented Apr 24, 2025 via email

Uh oh!

artlog commented Aug 5, 2025

Uh oh!

dartcafe commented Aug 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dartcafe Mar 25, 2025 •

edited

Loading