Skip to content

Improve Sharing Details Activity #2977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AndyScherzinger wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Improve Sharing Details Activity #2977

AndyScherzinger wants to merge 3 commits into from

Conversation

@AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Dec 24, 2025 •
edited
Loading

⚠️ Caution

🚀 Changes

  • Adds Toolbar at the top
  • Makes empty space at the bottom action-bar height sized instead on 100dp
  • Sets share note content in any case (currently also broken on Files client!), needs Add read/write note field logic to parcel processing android-library#1915 for it to work, else always broken
  • Updates date picker icon to outlined variant
  • Removes title setting on Share Activity by moving it to the layout itself since it is a static text

🖼️ Screenshot

402-1024

@AndyScherzinger AndyScherzinger added this to the 4.6.0 milestone Dec 24, 2025
@AndyScherzinger AndyScherzinger added 3. to review design Design and UX/UI issues labels Dec 24, 2025
@AndyScherzinger
style(sharing): Improve sharing activities' design
2a1042f 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
fix(sharing): Show share note in any case
5dafe04 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
TEST - remove before merging
c5d175c 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger force-pushed the feat/noid/NoteInShareDetailsView branch from 7b5dbd2 to c5d175c Compare December 24, 2025 14:55
@github-actions
Copy link
Contributor

github-actions bot commented Dec 25, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/2977.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

3. to review design Design and UX/UI issues

Projects

None yet

Milestone

4.6.0

Development

Successfully merging this pull request may close these issues.

2 participants

@AndyScherzinger