Skip to content

fix: use NcPasswordField for the password field in send modal #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyteinsky merged 1 commit into from
Dec 1, 2025
Merged

fix: use NcPasswordField for the password field in send modal #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/components/SendFilesModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,11 +173,10 @@
{{ t('integration_slack', 'Set link password') }}
</NcCheckboxRadioSwitch>
<div class="spacer" />
<input v-show="passwordEnabled"
id="password-input"
<NcPasswordField v-show="passwordEnabled"
v-model="password"
type="text"
:placeholder="passwordPlaceholder">
class="password-input"
:placeholder="passwordPlaceholder" />
</div>
</div>
<span class="field-label">
Expand Down Expand Up @@ -236,6 +235,7 @@ import NcDateTimePickerNative from '@nextcloud/vue/components/NcDateTimePickerNa
import NcHighlight from '@nextcloud/vue/components/NcHighlight'
import NcLoadingIcon from '@nextcloud/vue/components/NcLoadingIcon'
import NcModal from '@nextcloud/vue/components/NcModal'
import NcPasswordField from '@nextcloud/vue/components/NcPasswordField'
import NcRadioGroup from '@nextcloud/vue/components/NcRadioGroup'
import NcRadioGroupButton from '@nextcloud/vue/components/NcRadioGroupButton'
import NcSelect from '@nextcloud/vue/components/NcSelect'
Expand Down Expand Up @@ -292,6 +292,7 @@ export default {
CloseIcon,
AccountMultiple,
RefreshIcon,
NcPasswordField,
},

data() {
Expand Down Expand Up @@ -352,7 +353,7 @@ export default {
this.expirationEnabled = false
this.expirationDate = new Date()
this.passwordEnabled = false
this.password = null
this.password = ''
},
showModal() {
this.show = true
Expand All @@ -375,7 +376,7 @@ export default {
comment: this.comment,
permission: this.selectedPermission,
expirationDate: this.sendType === SEND_TYPE.public_link.id && this.expirationEnabled ? this.expirationDate : new Date(),
password: this.sendType === SEND_TYPE.public_link.id && this.passwordEnabled ? this.password : null,
password: this.sendType === SEND_TYPE.public_link.id && this.passwordEnabled ? this.password : '',
}
this.$el.dispatchEvent(
new CustomEvent('validate', {
Expand Down Expand Up @@ -509,7 +510,7 @@ export default {
margin-right: 20px;
}
:deep(#expiration-datepicker),
#password-input {
.password-input {
width: 250px;
margin: 0;
}
Expand Down
Loading