[Bug] Replace broken OC.dialogs.message by DialogBuilder #111
Merged
Conversation
…ud/dialogs Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
This was referenced Mar 23, 2026
janepie
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing if the UI issue reported in nextcloud/assistant#418 was affecting the modals in this apps, I spotted it was broken because we still use the old
OC.dialogs.messagewhich was removed in NC 34.OC.dialogs.messageby DialogBuilder from @nextcloud/dialogs