Fixes#4
Open
hamza221 wants to merge 7 commits into
Open
Conversation
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
hamza221
force-pushed
the
fix/leftover-naming
branch
from
21694ad to
f923df6
Compare
- createFile/put: normalize stream resource → string before assigning to
Entity::$data (?string), fixing TypeError on Sabre MOVE/COPY/chunked PUT
- getChild/childExists/getMultipleChildren: strip .vcf/.ics from the URI
segment before matching against the uuid column, fixing PROPFIND
"Entity not found" after a contact/event is moved into a DAVC collection
- Hybrid getACL: use ?: instead of ?? so an empty permissions array also
falls back to {DAV:}all, fixing the "Access denied" PROPFIND on
calendars/addressbooks whose permissions column was stored as []
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
After Sabre PUT/MOVE, the immediate PROPFIND failed with "Entity not
found" because we stored uuid = parsed vCard/iCal UID, while Sabre
looks up by the URI segment the client chose. The two are independent
per RFC 6352/4791 and can — and in practice do — differ.
- Hybrid createFile: strip extension and set $eo->uuid = $id so the
URI segment becomes the stored lookup key.
- Cached createFile: override the uuid that extractProperties()
extracted from the payload with the URI segment $id.
- LocalContactsService / LocalEventsService fromEntityModel: honor
$so->uuid when set, falling back to vCard/iCal UID extraction so
the harmonization path (which leaves $so->uuid null) is unaffected.
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
- Add loading state to the Connect button (disabled + spinner + "Connecting…" label) and guard against re-entry while a connect is in flight. - Await serviceList() after connect and re-point selectedService to the matching entry from the refreshed list so NcSelect's v-model lines up with one of its options. Previously the new account only appeared in the dropdown after a page reload. - Disable the disconnect button when no service is selected. - Replace the single shared, re-randomizing NcColorPicker with a per-row picker bound to each correlation's color via setContactCorrelationColor / setEventCorrelationColor. Add a picker to the contacts row to match the calendars row. - Persist a random color once when a correlation is created (or on first toggle of a legacy correlation without a color) instead of generating a new randomColor() on every render. Stops the icon color from changing on every re-render and lets the color be saved through localCollectionsDeposit. - Drop the unused selectedcolor ref and global color computed. Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
Collaborator
|
Hey, I have pull a bunch of the files out of this PR to break them down in to smaller commits. I tried to re-base it but can't because your branch is behind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm testing the app and creating fixes as I go (hit bugs, blockers)
divided into small commits for easy review