Skip to content

[stable-34.0] feature: add search dialog to new tray menu#10349

Merged
nilsding merged 4 commits into
stable-34.0from
backport/10331/stable-34.0
Jul 10, 2026
Merged

[stable-34.0] feature: add search dialog to new tray menu#10349
nilsding merged 4 commits into
stable-34.0from
backport/10331/stable-34.0

Conversation

@backportbot

@backportbot backportbot Bot commented Jul 10, 2026

Copy link
Copy Markdown

Backport of PR #10331

Rello and others added 4 commits July 10, 2026 11:02
Signed-off-by: Rello <github@scherello.de>
Expose isFetchMoreInProgress, hasSearchTerm, hasSearchError, canEditSearch
and a computed SearchState enum as model properties, replacing the derived
booleans in SearchWindow.qml.

Assisted-by: Claude:claude-opus-4-8
Signed-off-by: Camila Ayres <hello@camilasan.com>
Add cases for placeholder, skeleton, results, nothing found and search
error states, plus the derived boolean properties.

Assisted-by: Claude:claude-opus-4-8
Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Rello <github@scherello.de>
@backportbot backportbot Bot requested a review from i2h3 July 10, 2026 11:02
@backportbot backportbot Bot requested a review from nilsding as a code owner July 10, 2026 11:02
@backportbot backportbot Bot requested review from Rello and nilsding July 10, 2026 11:02
@backportbot backportbot Bot added os: 🍎 macOS Apple macOS, formerly also known as OS X os: 🚪 Windows os: 🐧 Linux 3. to review design Design, UI, UX, etc. labels Jul 10, 2026
@backportbot backportbot Bot added this to the 34.0.0 milestone Jul 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-10349.zip

Digest: sha256:5919fce30e229bb68c01afb62418d394cba8f09ff6c923813d6a78aed922da45

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@nilsding nilsding enabled auto-merge July 10, 2026 11:14
@nilsding nilsding merged commit 0770952 into stable-34.0 Jul 10, 2026
17 checks passed
@nilsding nilsding deleted the backport/10331/stable-34.0 branch July 10, 2026 11:26
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
63.3% Coverage on New Code (required ≥ 80%)
15 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

💡 Need a hand with PR review? Try Gitar by Sonar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review design Design, UI, UX, etc. os: 🍎 macOS Apple macOS, formerly also known as OS X os: 🚪 Windows os: 🐧 Linux

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants