feat(EditSimple): show alarms in viewing mode#7790
feat(EditSimple): show alarms in viewing mode#7790SebastianKrupinski merged 1 commit intonextcloud:mainfrom
Conversation
Signed-off-by: Abhinav Ohri <abhinavohri13@gmail.com>
abhinavohri
requested review from
GVodyanov,
SebastianKrupinski and
tcitworld
as code owners
|
Hi @abhinavohri Thank you for the pull request! Can you post a before and after picture of the changes, so that design can review the changes. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
SebastianKrupinski
added
3. to review
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
Looks good to me for parity with Gcal! |
Perfect, I'll review the code and functionality then. |
|
Tested. Looks good and works 
|
3 participants
Resolves: #7780
Summary:
Display alarms in the simple event editor when viewing events in read-only mode.
Before:
After:
