feat: cache python packages for speedup(DOCKER_BUILDKIT=1)#41
Merged
oleksandr-nc merged 3 commits intomainfrom Mar 26, 2025
Merged
feat: cache python packages for speedup(DOCKER_BUILDKIT=1)#41oleksandr-nc merged 3 commits intomainfrom
oleksandr-nc merged 3 commits intomainfrom
Conversation
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
oleksandr-nc
force-pushed
the
feat/use-DOCKER_BUILDKIT
branch
from
65407ef to
23d2ce1
Compare
kyteinsky
reviewed
Mar 26, 2025
Contributor
kyteinsky
left a comment
kyteinsky
left a comment
There was a problem hiding this comment.
sounds great!
It was a pain for dev setups when small dependencies changed and the pip install layer invalidated.
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of downloading packages for ExApp in python every time, we can ask docker to keep them in a separate volume and use from there. (not much speed for skeleton, but for any program that uses PyTorch it is a huge plus)
What do you think about it?
Edited: Also changed Docker file to use stage build - to allow use this in GitHub Actions without modification.