Open
Conversation
Author
|
And I'll start by fixing some conflicts 👍 |
p1gp1g
force-pushed
the
feat/unifiedpush
branch
from
55b0b2a to
5cf0a27
Compare
Signed-off-by: sim <git@sgougeon.fr>
The capability doesn't have an accountName, and therefore doesn't update the user cache Signed-off-by: sim <git@sgougeon.fr>
…e message Signed-off-by: sim <git@sgougeon.fr>
Signed-off-by: sim <git@sgougeon.fr>
Signed-off-by: sim <git@sgougeon.fr>
Signed-off-by: sim <git@sgougeon.fr>
Signed-off-by: sim <git@sgougeon.fr>
Signed-off-by: sim <git@sgougeon.fr>
Signed-off-by: sim <git@sgougeon.fr>
…ilable Signed-off-by: sim <git@sgougeon.fr>
Signed-off-by: sim <git@sgougeon.fr>
To catch easily when we do UnifiedPush or Common push tasks Signed-off-by: sim <git@sgougeon.fr>
Signed-off-by: sim <git@sgougeon.fr>
… a distributor Signed-off-by: sim <git@sgougeon.fr>
Signed-off-by: sim <git@sgougeon.fr>
Signed-off-by: sim <git@sgougeon.fr>
Signed-off-by: sim <git@sgougeon.fr>
…nregistration Signed-off-by: sim <git@sgougeon.fr>
Signed-off-by: sim <git@sgougeon.fr>
p1gp1g
force-pushed
the
feat/unifiedpush
branch
from
5cf0a27 to
84bf56d
Compare
p1gp1g
commented
Feb 17, 2026
| private fun appTypes(): List<String> = context.packageManager | ||
| .getLaunchIntentForPackage(APP_NEXTCLOUD_TALK)?.let { | ||
| listOf("all", "-talk") | ||
| } ?: listOf("all") |
Author
There was a problem hiding this comment.
That is to get all notifications, except talk ones if talk is installed. But:
- We can decide to never receive talk notifications (if a user wants talk notif, they probably use Talk app)
- And it would be better to list the applications we want to receive notifications from
There was a problem hiding this comment.
What about talk notifications? Is it expected that the talk app will independently handle unifiedpush notifications too?
Author
There was a problem hiding this comment.
I'm cleaning up the code to open the pull request
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following web push support in nextcloud/notifications, we can add UnifiedPush support to the Android application*, to get push notifications even without the Play Services.
The implementation follows this guide: https://unifiedpush.org/developers/ux/
This feature also gives the possibility to get Push Notifications with the Play Services, without the proxy (Nextcloud servers directly push to Google FCM servers), and without a proprietary library. So this is an accepted way to use FCM for application in F-Droid. => This is in a 2nd PR, already ready.
Fix #11898
Fix #5510
Fix #8684
Fix #3333 (with the 2nd PR)
* We could add it to the Linux app too, but I haven't, at least yet.
🖼️ Screenshots
Coming, I will update this description
🏁 Checklist