fix(device): improve battery charging status detection and robustness#16450
Draft
joshtrichards wants to merge 3 commits intomasterfrom
Draft
fix(device): improve battery charging status detection and robustness#16450joshtrichards wants to merge 3 commits intomasterfrom
joshtrichards wants to merge 3 commits intomasterfrom
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
|
test-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16450-Unit-test-19-54 |
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16450.apk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly a refactor (code modernization and readability), but also:
The charge status logic prevents false positives for "charging," such as when the device is plugged in but not actually charging and also handles weird devices and status results as robustly as possible.