Skip to content

fix: connectivity service#16232

Open
alperozturk96 wants to merge 21 commits into
masterfrom
fix/connectivity-serv
Open

fix: connectivity service#16232
alperozturk96 wants to merge 21 commits into
masterfrom
fix/connectivity-serv

Conversation

@alperozturk96
Copy link
Copy Markdown
Collaborator

@alperozturk96 alperozturk96 commented Jan 2, 2026 •
edited
Loading

  • Tests written, or not not needed

Fixes: #14681

Deduplicates isNetworkAndServerAvailable logic

Implements ConnectivityManager.NetworkCallback for better network state listening

Removes deprecated logics

Adds better documentation

Adds exception handling for http call to prevent temporary issues thus we don't inform user with incorrect availability state

Uses for metered detection NET_CAPABILITY_NOT_METERED instead of NET_CAPABILITY_NOT_RESTRICTED

Removes network change receiver uses listener for much better reaction to network change

Converts to Kotlin

This was referenced Jan 2, 2026
Closed
Open
Open
@nextcloud nextcloud deleted a comment from github-actions Bot Jan 27, 2026
@alperozturk96 alperozturk96 requested a review from ZetaTom January 27, 2026 10:56
ZetaTom

This comment was marked as resolved.

Sign in to view

@TheCrowned
Copy link
Copy Markdown

TheCrowned commented Feb 11, 2026

I gave this build a try - same error for me (both on upload, and on file listing).
The screenshot clearly shows network is available, both as WiFi and as data.
If it can help troubleshooting, upload works when I turn off WiFi and only leave data.
Screenshot_20260211-190409_Nextcloud QA

@alperozturk96 alperozturk96 force-pushed the fix/connectivity-serv branch from 4f091ab to 7b9830e Compare March 31, 2026 10:50
@alperozturk96 alperozturk96 added this to the Nextcloud App 33.1.0 milestone Mar 31, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot Mar 31, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot Mar 31, 2026
@alperozturk96 alperozturk96 force-pushed the fix/connectivity-serv branch from 7d56e29 to 4d47cb8 Compare April 7, 2026 11:21
@alperozturk96
Copy link
Copy Markdown
Collaborator Author

alperozturk96 commented Apr 7, 2026

@TheCrowned Hello. Thank you for the feedback. I updated the PR. Could you please check via latest APK file once its generated?

@nextcloud nextcloud deleted a comment from github-actions Bot Apr 7, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot Apr 7, 2026
@alperozturk96 alperozturk96 force-pushed the fix/connectivity-serv branch 2 times, most recently from 2181611 to 1fb36f6 Compare April 8, 2026 09:59
@alperozturk96 alperozturk96 added performance 🚀 Performance improvement opportunities (non-crash related) 2. developing and removed 3. to review labels Apr 8, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot Jun 1, 2026
@alperozturk96 alperozturk96 mentioned this pull request Jun 1, 2026
Open
4 tasks
@mahibi mahibi mentioned this pull request Jun 1, 2026
Open
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

APK file: https://github.com/nextcloud/android/actions/runs/26757419590/artifacts/7333754030
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

alperozturk96 and others added 21 commits June 2, 2026 08:52
@alperozturk96
fix: connectivity service impl
ab3a518 
# Conflicts:
#	app/src/main/java/com/nextcloud/client/network/ConnectivityServiceImpl.java
@alperozturk96
fix: connection service impl
3292a93 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
fix: connection service tests
ee52f4e 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
add wifi and metered check
21a5ef7 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
add logs
1a4b3a3 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
fix tests
f79b5d5 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fixes
e70b3ba 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 @ZetaTom
Update app/src/main/java/com/nextcloud/client/network/ConnectivitySer…
12d5648 
…vice.java

Co-authored-by: Tom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: Alper Öztürk <67455295+alperozturk96@users.noreply.github.com>
@alperozturk96
fix check
78b8aaf 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
Rename .java to .kt
24c9eae 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
convert to kt
4de3b44 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix walled logic
43231dc 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix isNetworkAndServerAvailable logic
f234f9b 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix network change listener
4b5178d 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
92449e1 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix tests
a51320e 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

# Conflicts:
#	gradle/libs.versions.toml
@alperozturk96
cache connectivity per account and address
7dbc88a 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
cache connectivity per account and address
7354433 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
9c3e06e 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

# Conflicts:
#	gradle/libs.versions.toml
@alperozturk96
wip
c727202 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
35ff71a 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the fix/connectivity-serv branch from e66654d to 35ff71a Compare June 2, 2026 05:56
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

APK file: https://github.com/nextcloud/android/actions/runs/26801398147/artifacts/7350124454
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

Codacy

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness6767
Dodgy code216215
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4242
Security1616
Total420419

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

test-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16232-Unit-test-06-01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZetaTom ZetaTom ZetaTom left review comments

Copilot code review Copilot Copilot left review comments

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees

No one assigned

Labels

2. developing performance 🚀 Performance improvement opportunities (non-crash related)

Projects

None yet

Milestone

Nextcloud App 33.1.0

Development

Successfully merging this pull request may close these issues.

Upload Failure with "No Internet Connection" Message After Upgrading to Version 3.31.0 on Android App

5 participants

@alperozturk96 @TheCrowned @AndyScherzinger @ZetaTom