Do not fetch shares during folder refresh by alperozturk96 · Pull Request #14989 · nextcloud/android

alperozturk96 · 2025-06-11T10:35:32Z

Tests written, or not not needed

Library PR: nextcloud/android-library#1741

Issue: nextcloud/files-clients#97

app/src/main/java/com/owncloud/android/ui/fragment/FileDetailSharingFragment.java

app/src/main/java/com/owncloud/android/ui/fragment/share/RemoteShareRepository.kt

app/src/main/java/com/owncloud/android/ui/fragment/FileDetailSharingFragment.java

pr is updated

alperozturk96 · 2025-06-13T09:19:01Z

@tobiasKaminsky Do we still need this?

RefreshFolderOperation#L281

if (!mSyncFullAccount) {
    sendLocalBroadcast(EVENT_SINGLE_FOLDER_SHARES_SYNCED, mLocalFolder.getRemotePath(), result);
}

tobiasKaminsky · 2025-07-18T06:31:07Z

/backport to stable-3.32

Signed-off-by: alperozturk <alper_ozturk@proton.me>

…ration runs on main thread it must be run on background thread thus executor is used. Signed-off-by: alperozturk <alper_ozturk@proton.me>

Signed-off-by: alperozturk <alper_ozturk@proton.me>

alperozturk96 · 2025-08-01T11:35:30Z

Fixed: When creating a public link share on the server and then refreshing on the client, the icon isn't updated to reflect that.

f2.mov

Fixed: When setting up a link share from the app and returning to file list, it also defaults to the create share (avatar plus) icon.

f1.mov

github-actions · 2025-08-01T11:43:05Z

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

github-actions · 2025-08-01T12:01:06Z

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14989.apk

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

alperozturk96 added the 2. developing label Jun 11, 2025

alperozturk96 commented Jun 12, 2025

View reviewed changes

app/src/main/java/com/owncloud/android/ui/fragment/FileDetailSharingFragment.java Outdated Show resolved Hide resolved

alperozturk96 mentioned this pull request Jun 12, 2025

BugFix - Do not Filter Share Type nextcloud/android-library#1741

Merged

alperozturk96 requested a review from tobiasKaminsky June 12, 2025 08:13

alperozturk96 added 3. to review and removed 2. developing labels Jun 12, 2025

alperozturk96 requested review from ZetaTom and mpivchev June 12, 2025 08:13

alperozturk96 force-pushed the do-not-fetch-shares-during-folder-refresh branch from c7f5e37 to 04cca36 Compare June 12, 2025 08:20

alperozturk96 mentioned this pull request Jun 12, 2025

Use only webdav for sharing information nextcloud/files-clients#97

Closed

ZetaTom reviewed Jun 12, 2025

View reviewed changes

app/src/main/java/com/owncloud/android/ui/fragment/share/RemoteShareRepository.kt Outdated Show resolved Hide resolved

app/src/main/java/com/owncloud/android/ui/fragment/FileDetailSharingFragment.java Outdated Show resolved Hide resolved

alperozturk96 removed the request for review from mpivchev June 12, 2025 13:37

alperozturk96 force-pushed the do-not-fetch-shares-during-folder-refresh branch from 04cca36 to df32926 Compare June 12, 2025 13:38

alperozturk96 requested a review from ZetaTom June 12, 2025 13:39

This comment was marked as resolved.

Sign in to view

alperozturk96 force-pushed the do-not-fetch-shares-during-folder-refresh branch from a7d1bee to 29cc7d0 Compare June 13, 2025 07:00

alperozturk96 requested a review from ZetaTom June 13, 2025 07:52

nextcloud deleted a comment from github-actions bot Jun 13, 2025

alperozturk96 added the ux-enhancement Improvements that refine user interactions, accessibility, or overall usability label Jun 13, 2025

nextcloud deleted a comment from github-actions bot Jun 13, 2025

alperozturk96 added the performance 🚀 Performance improvement opportunities (non-crash related) label Jun 13, 2025

alperozturk96 force-pushed the do-not-fetch-shares-during-folder-refresh branch from e75cc04 to 39cac1a Compare June 18, 2025 06:56

alperozturk96 force-pushed the do-not-fetch-shares-during-folder-refresh branch 2 times, most recently from 7d332d6 to 8cc61ea Compare July 3, 2025 07:29

backportbot bot added the backport-request label Jul 18, 2025

alperozturk96 force-pushed the do-not-fetch-shares-during-folder-refresh branch from 8cc61ea to 9d8eb95 Compare July 18, 2025 07:06

tobiasKaminsky approved these changes Jul 22, 2025

View reviewed changes

alperozturk96 added 16 commits August 1, 2025 11:51

fix FileDownloadLimit crash

4a70e9e

Signed-off-by: alperozturk <alper_ozturk@proton.me>

setDownloadLimitToContentValues

a3116ed

Signed-off-by: alperozturk <alper_ozturk@proton.me>

support avatar generation for external shares

0656dc7

Signed-off-by: alperozturk <alper_ozturk@proton.me>

fix operation creation from remotefile object

edf5dcb

Signed-off-by: alperozturk <alper_ozturk@proton.me>

fix operation creation from remotefile object

bcce01d

Signed-off-by: alperozturk <alper_ozturk@proton.me>

fix ss test, pass correct argument

609b8f3

Signed-off-by: alperozturk <alper_ozturk@proton.me>

check token NPE

f485300

Signed-off-by: alperozturk <alper_ozturk@proton.me>

listen completions of the remote operation

b7010ea

Signed-off-by: alperozturk <alper_ozturk@proton.me>

add shimmering

c1c17ab

Signed-off-by: alperozturk <alper_ozturk@proton.me>

add share_list_item_shimmer.xml

03b38f3

Signed-off-by: alperozturk <alper_ozturk@proton.me>

add blink animation

4ff2cbb

Signed-off-by: alperozturk <alper_ozturk@proton.me>

kt spotless fix

2334dcb

Signed-off-by: alperozturk <alper_ozturk@proton.me>

extract layouts

511f9f0

Signed-off-by: alperozturk <alper_ozturk@proton.me>

fix git conflict

16dc863

Signed-off-by: alperozturk <alper_ozturk@proton.me>

fix git conflict

d68bb85

Signed-off-by: alperozturk <alper_ozturk@proton.me>

fix kt spotless

d99c1b7

Signed-off-by: alperozturk <alper_ozturk@proton.me>

alperozturk96 force-pushed the do-not-fetch-shares-during-folder-refresh branch from 39609ff to d99c1b7 Compare August 1, 2025 09:51

alperozturk96 added 5 commits August 1, 2025 12:20

use correct android lib version

a8f051a

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Rename .java to .kt

d153c07

Signed-off-by: alperozturk <alper_ozturk@proton.me>

fetch updated data

30b45ed

Signed-off-by: alperozturk <alper_ozturk@proton.me>

since startSyncFolderOperation called onResume and startSyncFolderOpe…

c7dded7

…ration runs on main thread it must be run on background thread thus executor is used. Signed-off-by: alperozturk <alper_ozturk@proton.me>

revert

d09c82c

Signed-off-by: alperozturk <alper_ozturk@proton.me>

alperozturk96 marked this pull request as ready for review August 1, 2025 11:33

alperozturk96 merged commit cdb2893 into master Aug 1, 2025
13 of 19 checks passed

alperozturk96 deleted the do-not-fetch-shares-during-folder-refresh branch August 1, 2025 11:36

backportbot bot mentioned this pull request Aug 1, 2025

[stable-3.32] Do not fetch shares during folder refresh #15292

Merged

backportbot bot removed the backport-request label Aug 1, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Do not fetch shares during folder refresh#14989

Do not fetch shares during folder refresh#14989
alperozturk96 merged 31 commits intomasterfrom
do-not-fetch-shares-during-folder-refresh

alperozturk96 commented Jun 11, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

alperozturk96 commented Jun 13, 2025

Uh oh!

tobiasKaminsky commented Jul 18, 2025

Uh oh!

alperozturk96 commented Aug 1, 2025

Uh oh!

Uh oh!

github-actions bot commented Aug 1, 2025

Uh oh!

github-actions bot commented Aug 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Uh oh!

Conversation

alperozturk96 commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

alperozturk96 commented Jun 13, 2025

Uh oh!

tobiasKaminsky commented Jul 18, 2025

Uh oh!

alperozturk96 commented Aug 1, 2025

Uh oh!

Uh oh!

github-actions bot commented Aug 1, 2025

Uh oh!

github-actions bot commented Aug 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

alperozturk96 commented Jun 11, 2025 •

edited

Loading