Prevent Unnecessary UpdateShareRemoteOperation Calls

[alperozturk96]

Instead of executing the PUT method for each parameter update using client.executeMethod(put) inside the loop, we can first build all the parameters in the loop and then execute the PUT method only once.

To observe this behavior, open the Android Files app, update any share, and check the log or place a debugger in the UpdateShareRemoteOperation class.

[github-actions]

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	161

[ZetaTom]

Please consider using com.nextcloud.common.JSONRequestBody. Other than this everything looks good and works.

[github-actions]

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	161

[github-actions]

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	161

[github-actions]

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	161

[codecov]

Codecov Report

Attention: Patch coverage is 72.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 43.07%. Comparing base (d862794) to head (37d4709).
Report is 8 commits behind head on master.

Files with missing lines	Patch %	Lines
...b/resources/shares/UpdateShareRemoteOperation.java	72.00%	6 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #1722   +/-   ##
=========================================
  Coverage     43.06%   43.07%           
  Complexity      988      988           
=========================================
  Files           235      235           
  Lines          8568     8562    -6     
  Branches       1123     1119    -4     
=========================================
- Hits           3690     3688    -2     
+ Misses         4364     4359    -5     
- Partials        514      515    +1     

Files with missing lines	Coverage Δ
...b/resources/shares/UpdateShareRemoteOperation.java	59.42% <72.00%> (+2.08%)	⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	161

[github-actions]

SpotBugs

Category	Base	New
Bad practice	35	34
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	160

[github-actions]

SpotBugs

Category	Base	New
Bad practice	35	34
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	160

[tobiasKaminsky]

https://docs.nextcloud.com/server/latest/developer_manual/client_apis/OCS/ocs-share-api.html#update-share

@skjnldsv @come-nc (since you are app owner of files_sharing)
above documentation says:

Only one of the update parameters can be specified at once.

But according to Alper's test multiple parameter work.
So, is this documentation outdated, or are some combinations not allowed?

[come-nc]

This note dates from before my time. I see nothing in the controller code indicating such a limitation 🤷

[github-actions]

SpotBugs

Category	Base	New
Bad practice	35	34
Correctness	34	35
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	161