Skip to content

[stable-2.19] Inject Session Time Out To The Remote Operation Constructors#1633

Merged
tobiasKaminsky merged 9 commits intostable-2.19from
backport/1597/stable-2.19
Jan 17, 2025
Merged

[stable-2.19] Inject Session Time Out To The Remote Operation Constructors#1633
tobiasKaminsky merged 9 commits intostable-2.19from
backport/1597/stable-2.19

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Jan 16, 2025

Backport of PR #1597

Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@github-actions
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@codecov
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 210 lines in your changes missing coverage. Please review.

Project coverage is 48.93%. Comparing base (682baac) to head (0484a07).
Report is 11 commits behind head on stable-2.19.

Files with missing lines Patch % Lines
.../resources/e2ee/UpdateMetadataV2RemoteOperation.kt 0.00% 49 Missing ⚠️
...b/resources/e2ee/StoreMetadataV2RemoteOperation.kt 0.00% 41 Missing ⚠️
.../lib/resources/e2ee/UnlockFileV1RemoteOperation.kt 0.00% 26 Missing ⚠️
...esources/users/CheckRemoteWipeRemoteOperation.java 0.00% 10 Missing ⚠️
...id/lib/resources/e2ee/LockFileRemoteOperation.java 0.00% 9 Missing ⚠️
...b/resources/e2ee/StoreMetadataRemoteOperation.java 0.00% 8 Missing ⚠️
.../resources/e2ee/UpdateMetadataRemoteOperation.java 0.00% 8 Missing ⚠️
...ources/users/RemoteWipeSuccessRemoteOperation.java 0.00% 8 Missing ⚠️
...urces/files/RestoreFileVersionRemoteOperation.java 0.00% 7 Missing ⚠️
...es/trashbin/RemoveTrashbinFileRemoteOperation.java 0.00% 7 Missing ⚠️
... and 11 more
Additional details and impacted files
@@                Coverage Diff                @@
##             stable-2.19    #1633      +/-   ##
=================================================
- Coverage          48.93%   48.93%   -0.01%     
- Complexity           996     1008      +12     
=================================================
  Files                206      207       +1     
  Lines               7833     7907      +74     
  Branches            1019     1019              
=================================================
+ Hits                3833     3869      +36     
- Misses              3450     3488      +38     
  Partials             550      550              
Files with missing lines Coverage Δ
...rces/users/GenerateAppPasswordRemoteOperation.java 80.76% <100.00%> (+3.49%) ⬆️
...c/main/java/com/nextcloud/common/SessionTimeOut.kt 100.00% <100.00%> (ø)
...esources/e2ee/ToggleEncryptionRemoteOperation.java 68.75% <100.00%> (+3.23%) ⬆️
...d/lib/resources/files/ReadFileRemoteOperation.java 81.25% <87.50%> (+1.93%) ⬆️
...lib/resources/files/RemoveFileRemoteOperation.java 76.19% <85.71%> (+3.96%) ⬆️
...ace/RichWorkspaceDirectEditingRemoteOperation.java 75.00% <75.00%> (+2.58%) ⬆️
.../lib/resources/files/CheckEtagRemoteOperation.java 77.41% <77.77%> (+2.41%) ⬆️
...b/resources/files/CreateFolderRemoteOperation.java 80.00% <80.00%> (+5.00%) ⬆️
...d/lib/resources/files/CopyFileRemoteOperation.java 61.36% <75.00%> (+2.82%) ⬆️
...lib/resources/files/RenameFileRemoteOperation.java 72.97% <72.72%> (+2.38%) ⬆️
... and 14 more

@tobiasKaminsky tobiasKaminsky merged commit c72125f into stable-2.19 Jan 17, 2025
12 of 18 checks passed
@tobiasKaminsky tobiasKaminsky deleted the backport/1597/stable-2.19 branch January 17, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments