-
Notifications
You must be signed in to change notification settings - Fork 138
[충남대 BE_신성희] 미션 제출합니다. #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Shsin9797
wants to merge
30
commits into
next-step:main
Choose a base branch
from
Shsin9797:shsin9797
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[좋았던점]
이전에 두 번 풀어본 문제인데, 한번 더 풀어볼 기회를 가질 수 있어서 좋았고, 이전에 풀었던 것에 비해 더 깔끔하게 작성하는 것을 보니 많이 발전했음을 확인할 수 있어 좋았습니다. 그리고 다른친구들의 코드도 참고하면서 제 코드를 수정해보고, 테스트 코드도 새롭게 짜보며 같은 문제임에도 여러관점에서 볼 수 있음을 알게되었습니다.
[아쉬운점]
mvc 패턴 등에 대해 모르고 있다보니 어떻게 해야 클린 코드를 작성할 수 있는지를 모르겠어서 고수인 친구들 코드와 비교되는데 어디를 어떻게 고치기 시작해야할지 감이 안잡혀서 아쉬웠습니다... 그리고 테스트 코드를 고수인 친구들꺼도 참고하고 gpt 도 참고하고 구글링도 해서 나름대로 작성해보았는데 자꾸 에러만 떠서 힘들었습니다... 어떻게 고쳐야 할지 감이 안잡히네요... 콘솔에도 제대로된 설명이 안나와서 아쉬웠습니다... 나름대로 작성했다고 생각했는데 실행이 안되는데 어디가 문제인지 모를때가 제일 심적으로 힘들었던것 같습니다.. .