Redesign/update webpack config#104
Open
bsutt123 wants to merge 11 commits intonewhavenio:tailwind-redesignfrom
Open
Redesign/update webpack config#104bsutt123 wants to merge 11 commits intonewhavenio:tailwind-redesignfrom
bsutt123 wants to merge 11 commits intonewhavenio:tailwind-redesignfrom
Conversation
maxx1128
approved these changes
Aug 13, 2018
Member
maxx1128
left a comment
maxx1128
left a comment
There was a problem hiding this comment.
I'm not too familiar with webpack, but this seems good to me. I'd recommend someone with more experience here to also take a look though.
maxx1128
force-pushed
the
tailwind-redesign
branch
2 times, most recently
from
7ec35be to
0d0ee3c
Compare
maxx1128
force-pushed
the
tailwind-redesign
branch
from
0d0ee3c to
7da563b
Compare
maxx1128
force-pushed
the
tailwind-redesign
branch
from
7da563b to
3bbf72b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Max! I updated the webpack config to use webpack 4 rather than 3 (they added a lot of sane defaults in that I thought would be cool for us to take advantage of) and made the configuration just a bit more modular.
You can now specify type of build you want from the command line (development or production) and automatically apply base config, anything we put in the mode specific config and apply any presets that the command line specifies.
I also removed some of the old npm modules that we weren't really using (like react) and stopped using babel to load jsx, because it isn't really necessary.
Let me know if you like it. I also double checked and
yarn startis still working like a charm. I have no idea how to do the test-pa11y thing but if start and webpack are still working, I can't imagine I broke it too much.