Skip to content

chore: remove redundant step-level node 24 forces flag#87

Merged
neverinfamous merged 2 commits intomainfrom
fix/redundant-workflow-env
Apr 6, 2026
Merged

chore: remove redundant step-level node 24 forces flag#87
neverinfamous merged 2 commits intomainfrom
fix/redundant-workflow-env

Conversation

@neverinfamous
Copy link
Copy Markdown
Owner

Addresses Copilot AI review by eliminating redundant, unquoted step-level overrides of FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 and fixing lingering checkout action versions.

Copilot AI review requested due to automatic review settings April 6, 2026 13:33
@neverinfamous neverinfamous enabled auto-merge (squash) April 6, 2026 13:33
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Apr 6, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
do-manager 8a10791 Apr 06 2026, 01:33 PM

@neverinfamous neverinfamous merged commit 92f6c85 into main Apr 6, 2026
13 checks passed
@neverinfamous neverinfamous deleted the fix/redundant-workflow-env branch April 6, 2026 13:34
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates GitHub Actions workflows to standardize the Node 24 forcing flag at the workflow level (as a quoted string) and remove redundant per-step overrides, while also correcting the checkout action version in the secrets scanning workflow.

Changes:

  • Add a clarifying comment and quote FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 as "true" in multiple workflows.
  • Remove the redundant step-level FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 env override from the Gitleaks step.
  • Change actions/checkout usage in secrets-scanning.yml from an invalid @v6 to @v4.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/secrets-scanning.yml Quotes the Node24 force env var, removes redundant step env, and updates checkout to @v4.
.github/workflows/docker-publish.yml Quotes the Node24 force env var and adds an explanatory comment.
.github/workflows/auto-release.yml Quotes the Node24 force env var and adds an explanatory comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 19 to 22
steps:
- name: Checkout code
uses: actions/checkout@v6
uses: actions/checkout@v4
with:
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description says it fixes lingering actions/checkout versions, but there are still workflow files using the non-existent actions/checkout@v6 (e.g. .github/workflows/codeql.yml and .github/workflows/lint-and-test.yml). Either update those workflows to a valid version (likely @v4) in this PR, or adjust the PR description/scope so it matches what’s actually changed.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants