Skip to content

chore: force GitHub actions to Node 24 runtime to silence deprecations#85

Merged
neverinfamous merged 1 commit intomainfrom
hotfix/force-node-24-actions
Apr 6, 2026
Merged

chore: force GitHub actions to Node 24 runtime to silence deprecations#85
neverinfamous merged 1 commit intomainfrom
hotfix/force-node-24-actions

Conversation

@neverinfamous
Copy link
Copy Markdown
Owner

Sets FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true globally

Copilot AI review requested due to automatic review settings April 6, 2026 13:20
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
do-manager a9cc352 Apr 06 2026, 01:21 PM

@neverinfamous neverinfamous merged commit f9b53c9 into main Apr 6, 2026
11 checks passed
@neverinfamous neverinfamous deleted the hotfix/force-node-24-actions branch April 6, 2026 13:22
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates GitHub Actions workflows to force JavaScript-based actions to run under a Node 24 runtime in order to suppress runtime deprecation warnings during CI.

Changes:

  • Add FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true at the workflow level for multiple workflows.
  • Update actions/checkout in the auto-release workflow to use @v4.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/secrets-scanning.yml Adds workflow-level env forcing Node 24 for JS actions.
.github/workflows/docker-publish.yml Adds workflow-level env forcing Node 24 for JS actions.
.github/workflows/auto-release.yml Adds workflow-level env forcing Node 24 and updates checkout action version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +9 to +11
env:
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true

Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

env values in GitHub Actions are treated as strings; using an unquoted YAML boolean here can be ambiguous/inconsistent with other env entries. Consider quoting the value (e.g., "true") and adding a short comment/link explaining why forcing Node 24 is needed, since this setting applies to all JavaScript-based actions in the workflow and could affect third-party actions unexpectedly.

Copilot uses AI. Check for mistakes.
env:
REGISTRY: docker.io
IMAGE_NAME: writenotenow/do-manager
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

env values in GitHub Actions are treated as strings; using an unquoted YAML boolean here can be ambiguous/inconsistent with other env entries. Consider quoting the value (e.g., "true") and adding a short comment/link explaining why forcing Node 24 is needed, since this setting applies to all JavaScript-based actions in the workflow and could affect third-party actions unexpectedly.

Suggested change
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
# Force JavaScript-based GitHub Actions in this workflow to run on Node 24.
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"

Copilot uses AI. Check for mistakes.
branches: [main]

env:
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

env values in GitHub Actions are treated as strings; using an unquoted YAML boolean here can be ambiguous/inconsistent with other env entries. Consider quoting the value (e.g., "true") and adding a short comment/link explaining why forcing Node 24 is needed, since this setting applies to all JavaScript-based actions in the workflow and could affect third-party actions unexpectedly.

Suggested change
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
# Force JavaScript-based actions in this workflow to run on Node 24.
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants