Skip to content

[code-quality] bug: dcf _write_standard_cells ignores li.format, alway#152

Open
neuralsignal wants to merge 1 commit into
mainfrom
claude/149--code-quality-bug-dcf-write-standard-cells-ignores
Open

[code-quality] bug: dcf _write_standard_cells ignores li.format, alway#152
neuralsignal wants to merge 1 commit into
mainfrom
claude/149--code-quality-bug-dcf-write-standard-cells-ignores

Conversation

@neuralsignal
Copy link
Copy Markdown
Owner

Closes #149

Summary

Auto-implemented by Claude from issue #149.

Test plan

  • Tests pass in CI
  • Code review approved
  • Manual verification (if applicable)

…ng currency (#149)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions github-actions Bot marked this pull request as ready for review May 22, 2026 10:16
@github-actions
Copy link
Copy Markdown
Contributor

Documentation Review

Files reviewed: excel_model/models/dcf.py, tests/test_models_dcf.py

Issues: None

  • _write_standard_cells is a private function; it already has a docstring and full type hints — no gap.
  • No public API functions were added or changed.
  • This is an internal bug fix (number format respects li.format instead of hardcoding "currency"); no README update needed.
  • CHANGELOG.md is auto-generated by release-please; no manual entry required.
  • No TODO/FIXME/HACK comments in either changed file.
  • New regression test includes a one-line docstring explaining the intent.

Verdict: LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[code-quality] bug: dcf _write_standard_cells ignores li.format, always applies currency format

1 participant