[build-ml-whl] Improve safety and logging#61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Improve general scripting safety and logging of
build-ml-whl.Details:
Recently, the build job started failing: https://github.com/neuralmagic/llm-compressor-testing/actions/runs/16765257143/job/47524176286
With the logging added in this branch’s initial commit, it was learned that this was due to the project adding another Makefile in a subdirectory, thus confusing the results which only ever expected to find a single Makefile:
The newly added
-maxdepth 2flag for this command limits the depths that it will search for the Makefile in a way that is compatible with our existing projects/usages and reduces the chances this particular issue will occur again. A further future-proofing would be to replace thefindusage with an input specifying the dir to run themakecommand, or at least have it optional so thefindcommand is a fallback if not specified.Test Plan: