This repository was archived by the owner on May 16, 2022. It is now read-only.
Fixed bug in binary search: replaced signed with unsigned comparison.#188
Open
svpetry wants to merge 1 commit intoneuecc:masterfrom
Open
Fixed bug in binary search: replaced signed with unsigned comparison.#188svpetry wants to merge 1 commit intoneuecc:masterfrom
svpetry wants to merge 1 commit intoneuecc:masterfrom
Conversation
(cherry picked from commit d562f7a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a bug in the code generation for the binary search in AutomataDictionary. A signed comparison is emitted where an unsigned one is needed. This can lead to strange situations where random fields are not deserialized dependent on their naming.