Draft
Conversation
added 2 commits
December 25, 2021 21:43
amtoaer
reviewed
Dec 25, 2021
pkg/handler/ipgw.go
Outdated
Comment on lines
64
to
65
| if strings.Contains(body, "Arrearage users") { | ||
| return fmt.Errorf("overdue") | ||
| if strings.Contains(body, "欠费用户") { | ||
| return fmt.Errorf("超时") |
Member
There was a problem hiding this comment.
这里 Arrearage users 是网关 api 返回的固定内容，不能翻译；后面的 overdue 应该翻译成”已超额“或”已欠费“。
Member
|
先指出个比较明显的错误，其它部分等翻译结束后再细看。
只是个人看法，具体要怎样做还是等等白的意见吧。🤣 |
Member
|
有更新直接push到提起pr的branch上就行了，不用每次新改动都开一个新pr |
secret翻译
Author
|
我修改了一下，学长们有时间的话review一下还有什么问题我来改
发自我的iPhone
… 在 2021年12月26日，05:10，unbyte ***@***.***> 写道：
有更新直接push到提起pr的branch上就行了，不用每次新改动都开一个新pr
我有时间再review一下
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.
|
Member
|
暂时 hang 住，下周出个版本带上语言切换 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
第一次用pr有点紧张。。。
secret不知道是不是用来本地加密数据用的，所以没敢乱翻译。其他部分大多数都翻译了一遍。❤️