Skip to content

fix empty expression in shell comment and footer formatting #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jth-nw merged 2 commits into from
Mar 9, 2026
Merged

fix empty expression in shell comment and footer formatting #430

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d52fb0b
fix: empty expression in shell comment and footer formatting
jth-nw Mar 9, 2026
425272a
Merge pull request #429 from netwrix/fix/doc-pr-workflow-fixes
jth-nw Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .github/workflows/claude-doc-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,14 +97,14 @@ jobs:
run: |
REVIEW_FILE="/tmp/doc-pr-review.md"
FOOTER=$'\n\n---\n\n'
FOOTER+='**What to do next:**\n\n'
FOOTER+='Comment `@claude` on this PR followed by your instructions to get help:\n\n'
FOOTER+='- `@claude fix all issues` — fix all Vale, Dale, and editorial issues\n'
FOOTER+='- `@claude fix only the Vale issues` — fix just the linting problems\n'
FOOTER+='- `@claude help improve the flow of this document` — get writing assistance\n'
FOOTER+='- `@claude explain the voice issues` — understand why something was flagged\n\n'
FOOTER+='You can ask Claude anything about the review or about Netwrix writing standards.\n\n'
FOOTER+='> Automated fixes are only available for branches in this repository, not forks.'
FOOTER+=$'**What to do next:**\n\n'
FOOTER+=$'Comment `@claude` on this PR followed by your instructions to get help:\n\n'
FOOTER+=$'- `@claude fix all issues` — fix all Vale, Dale, and editorial issues\n'
FOOTER+=$'- `@claude fix only the Vale issues` — fix just the linting problems\n'
FOOTER+=$'- `@claude help improve the flow of this document` — get writing assistance\n'
FOOTER+=$'- `@claude explain the voice issues` — understand why something was flagged\n\n'
FOOTER+=$'You can ask Claude anything about the review or about Netwrix writing standards.\n\n'
FOOTER+=$'> Automated fixes are only available for branches in this repository, not forks.'

if [ -f "$REVIEW_FILE" ]; then
BODY=$(cat "$REVIEW_FILE")
Expand Down Expand Up @@ -147,7 +147,7 @@ jobs:
echo "base_branch=$BASE_BRANCH" >> "$GITHUB_OUTPUT"
echo "is_fork=$(echo "$PR_DATA" | jq -r '.isCrossRepository')" >> "$GITHUB_OUTPUT"
# Check target branch here using the shell variable to avoid
# re-interpolating the output via ${{ }} (code injection risk).
# re-interpolating the output via expressions (code injection risk).
if [ "$BASE_BRANCH" = "dev" ]; then
echo "targets_dev=true" >> "$GITHUB_OUTPUT"
else
Expand Down
Loading