dev to main

.github/workflows/claude-documentation-fixer.yml

@@ -119,11 +119,11 @@ jobs:
 
             Follow these steps in order:
 
-            1. Use `gh pr diff ${{ steps.pr-info.outputs.number }}` to identify which lines are part of the PR diff.
+            1. Use `gh pr diff ${{ steps.pr-info.outputs.number }}` to get the diff. In the diff output, lines starting with `+` are lines added or changed by this PR. Lines starting with `-` were removed. Lines starting with a space are unchanged context lines.
 
             2. Use `gh pr view ${{ steps.pr-info.outputs.number }}` to get the list of changed files, then read the full content of each changed markdown file.
 
-            3. Run all three review passes on each file per your instructions, but report ONLY issues on lines that are NOT part of the PR diff.
+            3. Run all three review passes on the full content of each file. Report ONLY issues on lines that do NOT start with `+` in the diff — that is, lines that were not added or changed by this PR. This includes unchanged context lines (space prefix in the diff) and lines not shown in the diff at all.
 
             4. You MUST write your results ONLY to `/tmp/preexisting-issues.md` — always, even if there are no issues. Do not post a comment. Do not write anything else. Use this exact format:
 
@@ -151,6 +151,7 @@ jobs:
           python3 << 'PYTHON_EOF'
           import os
           import json
+          import re
           import subprocess
 
           pr_number = os.environ['PR_NUMBER']
@@ -164,24 +165,67 @@ jobs:
               "Note: Automated fixes are only available for branches in this repository, not forks."
           )
 
+          def normalize_issues(body):
+              """Normalize issue lines to single bullet points, same as the reviewer."""
+              src = body.split('\n')
+              result = []
+              i = 0
+              while i < len(src):
+                  line = src[i]
+                  # Convert heading format: ### Line N: ... → - Line N: ...
+                  m = re.match(r'^#{1,6}\s+(Line \d+:.+)$', line)
+                  if m:
+                      result.append(f'- {m.group(1)}')
+                      i += 1
+                      continue
+                  # Convert bold format: **Line N: title** + sub-bullets → - Line N: single line
+                  m = re.match(r'^\*\*(Line \d+:.*?)\*\*\s*$', line)
+                  if m:
+                      title = m.group(1).rstrip('.')
+                      i += 1
+                      parts = []
+                      while i < len(src) and re.match(r'^\s*[-*]\s+', src[i]):
+                          sub = re.sub(r'^\s*[-*]\s+', '', src[i])
+                          sub = re.sub(r'^(Issue|Fix|Description|Suggested change):\s*', '', sub, flags=re.IGNORECASE)
+                          if sub.strip():
+                              parts.append(sub.strip().rstrip('.'))
+                          i += 1
+                      combined = f'- {title}. {". ".join(parts)}.' if parts else f'- {title}.'
+                      result.append(combined)
+                      continue
+                  result.append(line)
+                  i += 1
+              return '\n'.join(result)
+
           def normalize_body(body):
-              """Keep only the expected structured content from the preexisting issues output."""
+              """Extract the ## Preexisting issues section without fluff, normalized to match reviewer format."""
               idx = body.find('## Preexisting issues')
               if idx == -1:
                   return '## Preexisting issues\nNone.'
               body = body[idx:]
-              clean_lines = []
-              for line in body.split('\n'):
+              # Strip any footer Claude may have appended after a --- divider
+              footer_idx = body.find('\n---')
+              if footer_idx != -1:
+                  body = body[:footer_idx]
+              # Strip any prose intro between the header and first subheading/content
+              lines = body.split('\n')
+              result = []
+              past_intro = False
+              for line in lines:
                   s = line.strip()
-                  if (s == '## Preexisting issues' or
-                          s.startswith('### ') or
-                          s.startswith('- Line ') or
-                          s == 'None.' or
-                          s == ''):
-                      clean_lines.append(line)
-              while clean_lines and not clean_lines[-1].strip():
-                  clean_lines.pop()
-              return '\n'.join(clean_lines)
+                  if s == '## Preexisting issues':
+                      result.append(line)
+                  elif not past_intro:
+                      if s.startswith('### ') or s == 'None.' or s == '':
+                          if s:
+                              past_intro = True
+                          result.append(line)
+                      # else: prose intro line — skip it
+                  else:
+                      result.append(line)
+              while result and not result[-1].strip():
+                  result.pop()
+              return normalize_issues('\n'.join(result))
 
           summary_path = '/tmp/preexisting-issues.md'
           if os.path.exists(summary_path):

docs/platgovsalesforce/changemanagement/approving_change_request.md

@@ -9,23 +9,22 @@ sidebar_position: 50
 Approvers are populated from the Change/Approval Policy for the Change Request. Approval
 notifications are sent when the Change Request owner advances the status to **Pending Approval**.
 
-1. Approver receives an email with a link to the Change Request.
+1. Approvers receive an email with a link to the Change Request.
 2. When the Change Request opens, **Approve** and **Reject** buttons are available at the top of the
    form:
 
-    - If all approvers approve the Change Request, the status is changed to **Approved**. Implement
-      the changes specified by the Change Request.
     - If an approver rejects the Change Request, the status is changed to **Rejected**. You can
-      return the Change Request to **In Progress**, edit it, and reset it to **Pending Approval** if
+      return the Change Request to **In Progress**, edit it, and re-submit it for approval if
       there are errors or omissions.
 
 3. Change Request owner [Completes and Validates the Change Request](/docs/platgovsalesforce/changemanagement/completing_change_request.md).
 
-Once the Change Request is approved, you cannot change the customizations attached to the Change
-Request.
+Once the Change Request is approved, you cannot change the customizations associated with it or make any other modifications to the record.
 
-You can add the **Strongpoint CR Approval Override** Permission Set to specific users. Users with
-this Permission Set can approve a Change Request independent of the governing policy. The default
-approve permission is no longer included with the System Administrator role. If you have a System
-Administrator or other user you want to be able to approve, assign the **Strongpoint CR Approval
-Override** Permission Set.
+You can add the **Netwrix CR Approval Override** Permission Set to specific users. Users with
+this Permission Set can approve a Change Request independently of the governing policy. 
+
+:::note
+The default approve permission is no longer included with the System Administrator role. If you have a System
+Administrator or other users you want to be able to approve, assign the **Netwrix CR Approval Override** Permission Set.
+:::

docs/platgovsalesforce/changemanagement/change_log_reportfolder_dashboardfolder.md

@@ -0,0 +1,72 @@
+# Change Log for ReportFolder and DashboardFolder
+
+## Overview
+This document describes the Change Log structure for Salesforce types "ReportFolder" and "DashboardFolder", following the Netwrix Style Guide.
+
+## Change Log Layout
+
+The Change Log is organized into two main panels:
+
+### 1. "GENERAL & COMPLIANCE" Panel
+
+#### Fields and Meanings:
+
+| Field | Description |
+|-------|-------------|
+| Actual Change Date | Timestamp of the effective change |
+| Customization Created By / Modified By | Users who created/last modified the customization record |
+| Customization | Link to the specific folder customization record |
+| Metadata Type | Indicates "ReportFolder" or "DashboardFolder" |
+| Reason | Explanation for the change (e.g., "Manual Update on Package") |
+| Package | The package where the change was logged |
+| Related Change Request | Reference to the associated Change Request (if any) |
+| Compliant Indicator | Compliance status according to the active policy |
+| Active | Whether the customization is currently active |
+
+### 2. "CHANGE DETAILS" Panel
+
+#### Fields and Meanings:
+
+| Field | Description |
+|-------|-------------|
+| Change Type | Type of operation (Added, Removed, Access Changed) |
+| Old Access Level / New Access Level | Previous and new access levels (e.g., View, Edit, Manage) |
+| Folder Access User | Target user who was granted or revoked access |
+| Parent Group | Public Group through which access was granted (if applicable) |
+| Parent Role | Role through which access was granted (if applicable) |
+| Change Overview | Human-readable explanation of the change |
+
+## Access Permission Behaviors
+
+### Parent Group
+- Direct user permission or via Role: "Parent Group" is empty
+- Permission through a Public Group: Shows the Public Group that provided the access
+
+### Parent Role
+- Direct user permission or via public group: "Parent Role" is empty
+- Permission through a Role: Shows the Role that provided the access
+
+## Additional Notes
+
+- Access changes are tracked with specific indicators:
+  - "Change Type" shows the nature of the modification
+  - When access is revoked, "Change Type" displays "Removed"
+- The layout is consistent for both ReportFolder and DashboardFolder
+- Complies with Netwrix public documentation on Customizations and Change Logs
+
+## UI Examples
+
+- GENERAL & COMPLIANCE panel (ReportFolder example)
+
+![UI Examples](/images/platgovsalesforce/changelogs/changelog_reporfolder_dashboardfolder_1.webp)
+
+- CHANGE DETAILS panel (access change details)
+
+![UI Examples](/images/platgovsalesforce/changelogs/changelog_reporfolder_dashboardfolder_2.webp)
+
+- Full Change Log view
+
+![UI Examples](/images/platgovsalesforce/changelogs/changelog_reporfolder_dashboardfolder_3.webp)
+
+## References
+- Additional Information: https://docs.netwrix.com/docs/platgovsalesforce/changemanagement/using_change_logs

docs/platgovsalesforce/changemanagement/completing_change_request.md

@@ -6,9 +6,7 @@ sidebar_position: 60
 
 # Completing and Validating a Change Request
 
-To complete and validate the Change Request:
-
-Once the changes are complete, validate the Change Request and mark it **Complete CR**.
+Once the changes are complete, validate the Change Request and mark it as **Completed** on the path. 
 
 1. Open **Change Requests** to view the list of Change Requests. You may have to change the filter
    from **Recently Viewed**.
@@ -18,5 +16,4 @@ Once the changes are complete, validate the Change Request and mark it **Complet
    you expected. Refer to [Comparing Environments](/docs/platgovsalesforce/tools/environment_comparison.md) for details.
 5. View the **Open Non-Compliant Changes** or **Compliant Changes** Change Management Reports
    (**Netwrix Dashboard** > **Reports** > **Change Enablement**).
-6. When all changes are validated, click **Complete CR** on the Change Request status bar to mark it
-   Completed.
+6. When all changes are validated, click **Complete** on the path.