Skip to content

Use gh pr diff for valid-line filter; fix preexisting issue format #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jth-nw merged 1 commit into from
Feb 24, 2026
Merged

Use gh pr diff for valid-line filter; fix preexisting issue format #308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions .github/workflows/claude-documentation-reviewer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,13 @@ jobs:
- Issues in PR changes: the issue is on a line that was added or modified in this PR
- Preexisting issues: the issue exists on a line that was not changed by this PR

Write your complete review to `/tmp/review-summary.md` using this exact structure:
Write your complete review to `/tmp/review-summary.md` using this exact structure — two sections, each containing a flat list of issues in the format from your instructions, with no subheadings, groupings, or extra nesting:

## Issues in PR changes
<list each issue using the format from your instructions, or "None." if there are none>
<flat list of issues in the format from your instructions, or "None." if there are none>

## Preexisting issues
<list each issue using the format from your instructions, or "None." if there are none>
<flat list of issues in the format from your instructions, or "None." if there are none>

Then fix ALL issues directly in the files using the Write and Edit tools. Do not post a PR comment. Do not commit or push.

Expand All @@ -111,7 +112,6 @@ jobs:
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
PR_NUMBER: ${{ github.event.pull_request.number }}
BASE_SHA: ${{ github.event.pull_request.base.sha }}
HEAD_SHA: ${{ github.event.pull_request.head.sha }}
REPO: ${{ github.repository }}
run: |
Expand Down Expand Up @@ -221,10 +221,10 @@ jobs:
comment['start_side'] = 'RIGHT'
return comment

def get_pr_diff_valid_lines(base_sha, head_sha):
"""Return the set of (file, line_number) in HEAD visible in the PR diff."""
def get_pr_diff_valid_lines(pr_number):
"""Return the set of (file, line_number) visible in GitHub's PR diff."""
result = subprocess.run(
['git', 'diff', '--unified=10', base_sha, head_sha],
['gh', 'pr', 'diff', pr_number, '--patch'],
capture_output=True, text=True,
)
valid = set()
Expand Down Expand Up @@ -260,7 +260,6 @@ jobs:

pr_number = os.environ['PR_NUMBER']
head_sha = os.environ['HEAD_SHA']
base_sha = os.environ['BASE_SHA']
repo = os.environ['REPO']

# Get diff of Claude's local edits vs HEAD
Expand All @@ -270,7 +269,7 @@ jobs:

# Filter to only lines visible in the PR diff — GitHub rejects suggestions
# on lines outside the diff context with HTTP 422.
pr_valid_lines = get_pr_diff_valid_lines(base_sha, head_sha)
pr_valid_lines = get_pr_diff_valid_lines(pr_number)
suggestions = []
for s in all_suggestions:
start = s.get('start_line', s['line'])
Expand Down
Loading