fix: skip codeowner notification for Admin Support tracking issues in claude-issue-labeler.yml#1037
Merged
Merged
Conversation
… claude-issue-labeler.yml
Contributor
Code ReviewNo correctness issues found. The change is minimal and well-scoped:
One minor note (non-blocking): the title-based guard could in principle be bypassed by a human opening an issue whose title starts with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
claude-issue-labeler.ymlStep 4 to cover Admin Support PR review tracking issues, which were incorrectly triggering codeowner team mentions and product label application.Changes
.github/workflows/claude-issue-labeler.yml: AddedISSUE_TITLEenv var to Step 4 and a new early-exit guard — skips codeowner notification when the issue title starts withAdmin: PR review(the title pattern used byauto-create-pr-tracking-issues.ymlfor the admin path).Testing
Dry-run of the Step 4 bash against issue #1035 (the admin tracking issue created for PR #1034 that triggered the bad labels):
=== Step 4 dry run ===
ISSUE_TITLE: Admin: PR review — Training may29 (PR #1034)
Labels found: AI:site
AI:docs
1secure
access-analyzer
identity-manager
pingcastle
Admin Support tracking issue — skipping codeowner notification
Labels are fetched,
kb/reviewguard passes through, and the new title check exits before any codeowner comment is posted.Closes #1036