-
Notifications
You must be signed in to change notification settings - Fork 65
Cookie updated by NetworkToCode Cookie Drift Manager Tool #737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Template:
```
{
"template": "https://github.com/networktocode-llc/cookiecutter-ntc.git",
"dir": "python",
"ref": "main",
"path": null
}
```
Cookie:
```
{
"remote": "https://github.com/networktocode/netutils.git",
"path": "/Users/jeffkala/Documents/GitHub/outputs/netutils",
"repository_path": "/Users/jeffkala/Documents/GitHub/outputs/netutils",
"dir": "",
"branch_prefix": "drift-manager",
"context": {
"codeowner_github_usernames": "@itdependsnetworks @jeffkala @qduk",
"full_name": "Network to Code, LLC",
"email": "opensource@networktocode.com",
"github_org": "networktocode",
"description": "Common helper functions useful in network automation.",
"project_name": "netutils",
"project_slug": "netutils",
"repo_url": "https://github.com/networktocode/netutils",
"base_url": "netutils",
"project_python_name": "netutils",
"project_python_base_version": "3.10",
"project_with_config_settings": "no",
"generate_docs": "yes",
"version": "1.15.1",
"original_publish_year": "2021",
"_template": "https://github.com/networktocode-llc/cookiecutter-ntc.git",
"_output_dir": "/Users/jeffkala/Documents/GitHub/outputs",
"_repo_dir": "/Users/jeffkala/.cookiecutters/cookiecutter-ntc/python",
"_checkout": "main"
},
"base_branch": "develop",
"remote_name": "origin",
"pull_request_strategy": "PullRequestStrategy.CREATE",
"post_actions": [],
"baked_commit_ref": "cb8b5e31dece5ab2663d2ffd218a96ca1ae794c5",
"draft": false
}
```
CLI Arguments:
```
{
"cookie_dir": "",
"input": true,
"json_filename": "",
"output_dir": "../outputs",
"push": true,
"template": "https://github.com/networktocode-llc/cookiecutter-ntc.git",
"template_dir": "python",
"template_ref": "main",
"pull_request": null,
"post_action": [],
"disable_post_actions": false,
"draft": null
}
```
Template:
```
{
"template": "https://github.com/networktocode-llc/cookiecutter-ntc.git",
"dir": "python",
"ref": "main",
"path": "/__w/cookiecutter-nautobot-app-drift-manager/cookiecutter-nautobot-app-drift-manager/cookiecutter-ntc/python"
}
```
Cookie:
```
{
"remote": "https://github.com/networktocode/netutils.git",
"path": "/tmp/tmppx3c8g92/netutils",
"repository_path": "/tmp/tmppx3c8g92/netutils",
"dir": "",
"branch_prefix": "drift-manager",
"context": {
"codeowner_github_usernames": "@itdependsnetworks @jeffkala @qduk",
"full_name": "Network to Code, LLC",
"email": "info@networktocode.com",
"github_org": "networktocode",
"description": "Common helper functions useful in network automation.",
"project_name": "netutils",
"project_slug": "netutils",
"repo_url": "https://github.com/networktocode/netutils",
"base_url": "netutils",
"project_python_name": "netutils",
"project_python_base_version": "3.9",
"project_with_config_settings": "no",
"generate_docs": "yes",
"version": "1.15.1",
"original_publish_year": "2025",
"_template": "/__w/cookiecutter-nautobot-app-drift-manager/cookiecutter-nautobot-app-drift-manager/cookiecutter-ntc/python",
"_output_dir": "/tmp/tmppx3c8g92",
"_repo_dir": "/__w/cookiecutter-nautobot-app-drift-manager/cookiecutter-nautobot-app-drift-manager/cookiecutter-ntc/python",
"_checkout": null
},
"base_branch": "develop",
"remote_name": "origin",
"pull_request_strategy": "PullRequestStrategy.UPDATE_OR_CREATE",
"post_actions": [],
"baked_commit_ref": "cb8b5e31dece5ab2663d2ffd218a96ca1ae794c5",
"draft": false
}
```
CLI Arguments:
```
{
"cookie_dir": "",
"input": false,
"json_filename": "",
"output_dir": "",
"push": true,
"template": "./cookiecutter-ntc",
"template_dir": "python",
"template_ref": "main",
"pull_request": "update-or-create",
"post_action": [],
"disable_post_actions": true,
"draft": null
}
```
| "base_url": "netutils", | ||
| "project_python_name": "netutils", | ||
| "project_python_base_version": "3.9", | ||
| "project_python_base_version": "3.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't hold up.. but i am still of the opinion, we should be using the latest by default, and CI should run the oldest. There are some idiosyncrasies, like I think ruff says to use the oldest version in the config.. but that is just the config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, I'll look again but this specific variable is for the min python version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, but the Dockerfile is using is, e.g.
ARG PYTHON_VER="3.10"
also, where is the max defined?
|
Before merging I'm just pending a response from Sirbu on a step that is needed in Pypi for trusted publishers. |
Template:
Cookie:
CLI Arguments: