raise error if JMSPath retunrs None

Author: lvrfrc87

netcompare/check_types.py

@@ -57,11 +57,6 @@ def get_value(output: Union[Mapping, List], path: str = "*", exclude: List = Non
         Returns:
             Evaluated data, may be anything depending on JMESPath used.
         """
-        try: 
-            json.loads(output)
-        except TypeError:
-            raise TypeError(f"'output' must be a valid JSON object. You have {type(output)}")
-        
         if exclude and isinstance(output, Dict):
             if not isinstance(exclude, list):
                 raise ValueError(f"Exclude list must be defined as a list. You have {type(exclude)}")
@@ -78,6 +73,9 @@ def get_value(output: Union[Mapping, List], path: str = "*", exclude: List = Non
 
         values = jmespath.search(jmespath_value_parser(path), output)
 
+        if values is None:
+            raise TypeError("JMSPath returned 'None'. Please, verify your JMSPath regex.")
+
         # check for multi-nested lists if not found return here
         if not any(isinstance(i, list) for i in values):
             return values

tests/test_bugs.py

@@ -5,23 +5,22 @@
 
 
 issue_67 = (
-    {"global": {"peers": {"10.1.0.0": "peer1", "10.2.0.0": "peer2"}}},
-    "TypeError: 'output' must be a valid JSON object. You have <class 'dict'>"
+    {"global": {"peers": {"10.1.0.0": "peer1", "10.2.0.0": "peer2"}}}
     )
 
 issue_67_test = [
     issue_67,
 ]
 
 
-@pytest.mark.parametrize("data, expected_output", issue_67_test)
-def test_issue_67(data, expected_output):
+@pytest.mark.parametrize("data", issue_67_test)
+def test_issue_67(data):
     """Resolve issue 67: https://github.com/networktocode-llc/netcompare/issues/67"""
     my_jmspath = "global[*]"
     my_check = CheckType.init(check_type="exact_match")
     with pytest.raises(TypeError) as error:
         my_check.get_value(output=data, path=my_jmspath)()  # pylint: disable=E0110
 
     assert (
-        "'output' must be a valid JSON object. You have <class 'dict'>" in error.value.__str__()
+        "JMSPath returned 'None'. Please, verify your JMSPath regex." in error.value.__str__()
     )