FIx 67

Author: lvrfrc87

netcompare/check_types.py

@@ -1,5 +1,6 @@
 """CheckType Implementation."""
 import re
+import json
 import warnings
 from typing import Mapping, Tuple, List, Dict, Any, Union
 from abc import ABC, abstractmethod
@@ -56,6 +57,11 @@ def get_value(output: Union[Mapping, List], path: str = "*", exclude: List = Non
         Returns:
             Evaluated data, may be anything depending on JMESPath used.
         """
+        try: 
+            json.loads(output)
+        except TypeError:
+            raise TypeError(f"'output' must be a valid JSON object. You have {type(output)}")
+        
         if exclude and isinstance(output, Dict):
             if not isinstance(exclude, list):
                 raise ValueError(f"Exclude list must be defined as a list. You have {type(exclude)}")

tests/test_bugs.py

@@ -6,7 +6,7 @@
 
 issue_67 = (
     {"global": {"peers": {"10.1.0.0": "peer1", "10.2.0.0": "peer2"}}},
-    []
+    "TypeError: 'output' must be a valid JSON object. You have <class 'dict'>"
     )
 
 issue_67_test = [
@@ -19,5 +19,9 @@ def test_issue_67(data, expected_output):
     """Resolve issue 67: https://github.com/networktocode-llc/netcompare/issues/67"""
     my_jmspath = "global[*]"
     my_check = CheckType.init(check_type="exact_match")
-    pre_value = my_check.get_value(output=data, path=my_jmspath)
-    assert pre_value == pre_value, ASSERT_FAIL_MESSAGE.format(output=pre_value, expected_output=expected_output)
+    with pytest.raises(TypeError) as error:
+        my_check.get_value(output=data, path=my_jmspath)()  # pylint: disable=E0110
+
+    assert (
+        "'output' must be a valid JSON object. You have <class 'dict'>" in error.value.__str__()
+    )