fix(#433): require EAP-TLS key and cert in builder#436
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR tightens validation in EapOptionsBuilder::build() so EAP-TLS configurations fail early when required TLS inputs are missing, aligning runtime behavior with the builder’s documented TLS example.
Changes:
- Reject EAP-TLS builds that omit both
private_key_pathandprivate_key_blob. - Reject EAP-TLS builds that omit both
client_cert_pathandclient_cert_blob. - Add unit tests covering missing TLS private key and missing client certificate.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
nmrs/src/api/models/wifi.rs |
Adds EAP-TLS-specific required-field validation during EapOptionsBuilder::build(). |
nmrs/src/api/models/tests.rs |
Adds unit tests to ensure missing TLS key/cert are rejected with IncompleteBuilder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EapOptionsBuilder::build()reject incomplete EAP-TLS configsprivate_key_pathorprivate_key_blobclient_cert_pathorclient_cert_blobThis keeps the existing builder API unchanged and moves TLS required-field checks earlier, matching the builder docs.