Skip to content

Remove bad output when using SHOW_SCMP_ONLY #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tzaeschke merged 1 commit into from
Dec 19, 2025
Merged

Remove bad output when using SHOW_SCMP_ONLY #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ TODO
- Use \t in summary output
- Investigate spurious 0-0:0 ASes in PingAll output

### Fixed

- Fixed mangled output with mode SHOW_SCMP_ONLY
[#31](https://github.com/netsec-ethz/scion-java-multiping/pull/31)

## [0.6.1] - 2025-12-12

### Changed
Expand Down
5 changes: 4 additions & 1 deletion src/main/java/org/scion/multiping/PingAll.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,9 @@ private void runAS(ParseAssignments.HostEntry remote) throws IOException {
if (paths.isEmpty()) {
String src = ScionUtil.toStringIA(service.getLocalIsdAs());
String dst = ScionUtil.toStringIA(remote.getIsdAs());
if (!SHOW_ONLY_ICMP) {
if (SHOW_ONLY_ICMP) {
clearPrintQueue();
} else {
println("WARNING: No path found from " + src + " to " + dst);
}
summary.incAsNoPathFound(remote.getIsdAs());
Expand Down Expand Up @@ -231,6 +233,7 @@ private void runAS(ParseAssignments.HostEntry remote) throws IOException {
summary.add(result);

if (msgs[0] == null) {
clearPrintQueue();
return;
}

Expand Down