tekton on-cel-expression

[jpinsonneau]

Improved tekton on-cel-expression

Can't rely on path change annotations as it's still TP for now.

Related PRs:
netobserv/flowlogs-pipeline#1164
netobserv/network-observability-console-plugin#1181
netobserv/network-observability-cli#439
netobserv/netobserv-ebpf-agent#863

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jpinsonneau for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jotak]

I'm not sure it worked, since the konflux job wasn't triggered?
I can see that tekton has those on-target-branch, on-path-change annotations (here), but maybe konflux uses an older version? I don't see them mentioned in the konflux doc: https://konflux-ci.dev/docs/end-to-end/building-tekton-tasks/

[jpinsonneau]

I'm not sure it worked, since the konflux job wasn't triggered? I can see that tekton has those on-target-branch, on-path-change annotations (here), but maybe konflux uses an older version? I don't see them mentioned in the konflux doc: https://konflux-ci.dev/docs/end-to-end/building-tekton-tasks/

Indeed that's a TP 😿
https://pipelinesascode.com/docs/guide/matchingevents/#matching-a-pipelinerun-to-specific-path-changes

Rolling back to on-cel-expression

[jotak]

the bundle on-pull-request fails, apparently because of requirements.txt missing - it is in the dockerignore but shouldn't

[github-actions]

New images:

• quay.io/netobserv/network-observability-operator:2985c42
• quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-2985c42
• quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-2985c42

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:2985c42 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-2985c42

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-2985c42
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

[jotak]

now it's /bin/sh: line 1: ./hack/update-build.sh: No such file or directory

[openshift-ci]

@jpinsonneau: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-operator	0c2e6ce	link	false	/test e2e-operator

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.