Skip to content

Conversation

@jotak
Copy link
Member

@jotak jotak commented Dec 16, 2025

  • Handle page reload / routed from url with react-router
  • Handle proxying to configured rules/alerts urls (in plugin, it uses the openshift console endpoints)

- Handle page reload / routed from url with react-router
- Handle proxying to configured rules/alerts urls (in plugin, it uses
  the openshift console endpoints)
@openshift-ci
Copy link

openshift-ci bot commented Dec 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign memodi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak
Copy link
Member Author

jotak commented Dec 17, 2025

fyi @npinaeva I'm doing some small improvements to raise the UX on the standalone console

@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

❌ Patch coverage is 0% with 49 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.42%. Comparing base (0d5a261) to head (48f9e96).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/handler/promproxy.go 0.00% 35 Missing ⚠️
pkg/server/routes.go 0.00% 4 Missing and 3 partials ⚠️
pkg/prometheus/client.go 0.00% 6 Missing ⚠️
pkg/config/config.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1173      +/-   ##
==========================================
- Coverage   53.64%   53.42%   -0.22%     
==========================================
  Files         205      206       +1     
  Lines       10545    10588      +43     
  Branches     1309     1309              
==========================================
  Hits         5657     5657              
- Misses       4371     4412      +41     
- Partials      517      519       +2     
Flag Coverage Δ
uitests 55.94% <ø> (ø)
unittests 46.65% <0.00%> (-0.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/config/config.go 47.32% <0.00%> (ø)
pkg/prometheus/client.go 0.00% <0.00%> (ø)
pkg/server/routes.go 51.61% <0.00%> (-5.53%) ⬇️
pkg/handler/promproxy.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant