Temporary use forked prometheus/common to fix ProxyURL unmarshalling#263
Merged
OlivierCazade merged 1 commit intonetobserv:mainfrom Jul 21, 2022
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #263 +/- ##
==========================================
- Coverage 61.63% 60.19% -1.44%
==========================================
Files 67 69 +2
Lines 3915 4095 +180
==========================================
+ Hits 2413 2465 +52
- Misses 1350 1469 +119
- Partials 152 161 +9
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
jpinsonneau
approved these changes
Jul 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created a pull request in the prometheus/common repository:
prometheus/common#394
Meanwhile, this PR change the dependency to point to our local fork so we can marshall/unmarshall loki HTTP config without Proxy errors.