Skip to content

Conversation

@amalija-ramljak
Copy link
Member

Changes

  • original eslint and prettier hooks were missing the stderr from the commands, which leads to confusion when it throws an error due to node version
  • error is displayed like in HGSTACK-938 new hooks #14

Testing

  • use wrong node version from the one defined in project
  • add a test change to and stage a js file
  • add JSLinter to pre-commit hooks
  • run git commit - should see error with node version being wrong (expected version...)
  • do the same with JSPrettier

minimal adding of hooks to pre-commit

{
    "action": "\\Netgen\\GitHooks\\Action\\JSLinter",
    "options": {
        "excluded_files": []
    }
},
{
    "action": "\\Netgen\\GitHooks\\Action\\JSPrettier",
    "options": {
        "excluded_files": []
    }
},

@amalija-ramljak amalija-ramljak self-assigned this Dec 17, 2024
@emodric emodric requested a review from iherak December 17, 2024 14:37
@emodric
Copy link
Member

emodric commented Dec 17, 2024

Needs CS Fixer.

@emodric emodric merged commit 7aa2ebb into master Dec 19, 2024
2 checks passed
@emodric emodric deleted the NGSTACK-957-git-hooks-node-version-error branch December 19, 2024 10:49
@emodric
Copy link
Member

emodric commented Dec 19, 2024

Thanks @amalija-ramljak !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants