chore: upgrade pcapplusplus from 23.09 to 24.09#763
Open
leoparente wants to merge 5 commits intodevelopfrom
Open
chore: upgrade pcapplusplus from 23.09 to 24.09#763leoparente wants to merge 5 commits intodevelopfrom
leoparente wants to merge 5 commits intodevelopfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7283e5a207
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Author
|
windows and MacOS builds are still broken. The plan is to fix them after every lib is properly upgraded. |
weyrick
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes several important improvements and fixes to the DNS layer implementation, build system, and Conan integration. The main themes are: fixing a critical bug in DNS resource handling, improving Conan/CMake integration, updating dependencies, and modernizing header usage.
Summary of most important changes:
DNS Layer Bug Fixes and Modernization
setNexResourceto the correctsetNextResourcein both header and implementation files, ensuring proper resource chaining and preventing potential runtime errors. [1] [2] [3] [4] [5] [6] [7]DnsResource::getDataLength()to prevent heap buffer overflows when parsing DNS resource data, improving robustness against malformed packets.#pragma oncein DNS-related headers for improved clarity and to prevent multiple inclusion issues. [1] [2] [3]DnsLayerEnums.h) to re-export types from PcapPlusPlus, reducing code duplication and ensuring consistency with upstream definitions.Conan and CMake Integration Improvements
CMakeLists.txtand related CMake scripts to ensure Conan's toolchain file is loaded after the firstfind_package(), and improved logic for handling compiler executables, C++ standard detection, and multi-configuration builds. [1] [2] [3] [4] [5] [6] [7]pcapplusplusfrom version23.09to24.09inconanfile.py, ensuring the project uses the latest features and fixes.Minor Improvements
DnsQuerythat accepts raw data explicit to prevent unintended implicit conversions.#pragma oncefor header protection. [1] [2]These changes collectively improve the reliability, maintainability, and modernity of the DNS layer code and its build system integration.